Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider adding other committer(s)? #122

Open
jrochkind opened this issue Sep 11, 2018 · 0 comments
Open

consider adding other committer(s)? #122

jrochkind opened this issue Sep 11, 2018 · 0 comments

Comments

@jrochkind
Copy link
Contributor

solr_wrapper is code that many blacklight and samvera developers really rely on.

I think @cbeer is very busy, and sometimes takes some time to get to solr_wrapper issues, which can really increase development time and inconvenience for developer users.

One example is the "mirror_url" feature, which is pretty crucial because of the way apache.org sometimes rate-limits travis IPs.

A mirror_url feature was first added by cbeer in March 2018. https://github.com/cbeer/solr_wrapper/pull/113/files

It was not included in a solr_wrapper release until 2.0.0 released Jun 27.

But it was released with a bug that makes it unusable for any solr version that isn't latest release on apache.org (as opposed to archive.apache.org).

One fix to this problem was provided by @jcoyne on July 25th, and is still unmerged/unreleased. #119

I think perhaps @dkinzer's #114 from Jan 26 actually may fix this same problem. When I asked about a release incuding the mirror_url feature in #116 in May, @dkinzer actually noted that the mirror_url feature wasn't working without #114. But it was released with the bug anyway, and #114 still remains unmerged/released.

Here at my place of work, we spent several hours re-debugging the same bug that jcoyne already had an unmerged PR for, and dkinzer may have also 8 months ago.

It would be a huge help if those existing PR's could be addressed, so we can keep using the mirror_url feature, to avoid getting rate-limited by apache.org. The only alternatives we can think of is a fork of solr_wrapper, or monkey-patching some of the bugfixes in -- neither of which are attractive options.

But I understand @cbeer may have other priorities on his time. @cbeer, would you consider adding other commiter(s) (with rubygems release rights) to help resolve this issue that's been outstanding for ~8 months, and others as they come up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant