2.13.6 #527
Merged
2.13.6 #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeltz
commented
May 26, 2021
build.sbt
Outdated
| scalaVersion := "2.13.5" | ||
| crossScalaVersions := Seq("2.11.12", "2.12.11", "2.12.12", "2.13.6", "2.13.3", "2.13.4", "2.13.5") | ||
| scalaVersion := "2.13.6" | ||
| crossScalaVersions := Seq("2.11.12", "2.12.11", "2.12.12", "2.12.13", "2.13.3", "2.13.4", "2.13.5", "2.13.6") |
There was a problem hiding this comment.
Latest 2.12 was updated to 2.13.6 by #523. This keeps the order and support for latest 2.12.
We might want to drop 2.12.11.
| @@ -109,7 +109,7 @@ final case class InspectionContext(global: Global, feedback: Feedback) { | |||
| } | |||
|
|
|||
| protected def isArray(tree: Tree): Boolean = tree.tpe.typeSymbol.fullName == "scala.Array" | |||
| protected def isTraversable(tree: Tree): Boolean = tree.tpe <:< typeOf[Traversable[Any]] | |||
| protected def isIterable(tree: Tree): Boolean = tree.tpe <:< typeOf[Iterable[Any]] | |||
| new context.Traverser { | ||
|
|
||
| import context.global._ | ||
|
|
||
| private val contexts = new mutable.Stack[ListBuffer[String]]() | ||
| private var contexts: List[ListBuffer[String]] = Nil |
There was a problem hiding this comment.
A var List is better than a mutable.Stack, so replacing it. Behavior is kept.
|
when this might get finished? |
|
Can this be reviewed any soon? |
|
hi! when this will get merged and published? |
|
@mccartney would you have some time to review/merge this any time soon? |
|
Ack. Thanks for tagging me. I somehow must've missed this PR. I'll attend to it this week. |
mccartney
approved these changes
Jun 16, 2021
This was referenced Jun 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Scala 2.13.6.
Refactors sbt syntax.
Fixes #520.
Inspired by #488.