Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bf: make getRaftLog() return a stream #126

Merged
merged 1 commit into from
Jan 17, 2018
Merged

bf: make getRaftLog() return a stream #126

merged 1 commit into from
Jan 17, 2018

Conversation

jonathan-gramain
Copy link
Contributor

Instead of returning a data blob, return the stream sent by the server
to manage memory better and avoid issues with toString() when blob is
too large.

@jonathan-gramain jonathan-gramain mentioned this pull request Nov 29, 2017
Merged
@jonathan-gramain
bf: make getRaftLog() return a stream
2a16b8e 
Instead of returning a data blob, return the stream sent by the server
to manage memory better and avoid issues with toString() when blob is
too large.
@jonathan-gramain jonathan-gramain force-pushed the bf/S3C-1134-streamGetRaftLog branch from 0b6d897 to 2a16b8e Compare November 29, 2017 20:02
@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor 

CONFLICT (add/add): Merge conflict in package.json

@jonathan-gramain jonathan-gramain changed the base branch from master to rel/7.2 November 29, 2017 20:03
@jonathan-gramain
Copy link
Contributor Author

@ironman-machine
SCALITY_ARSENAL_BRANCH=bf/S3C-1134-streamLogConsumer
try

lamphamsy
lamphamsy reviewed Nov 30, 2017
View reviewed changes
Copy link
Contributor

@lamphamsy lamphamsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This modification is really good. But it should sync with Metadata that uses also bucketClient.getRaftLog for functional tests: https://github.com/scality/MetaData/blob/rel/7.2/tests/functional/1300-api-http/test.js#L251

@scality scality deleted a comment from ironman-machine Dec 2, 2017
@scality scality deleted a comment from ironman-machine Dec 2, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from jonathan-gramain Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from jonathan-gramain Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from jonathan-gramain Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from jonathan-gramain Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from ironman-machine Dec 13, 2017
@scality scality deleted a comment from jonathan-gramain Dec 13, 2017
@bennettbuchanan
Copy link

@ironman-machine
SCALITY_BACKBEAT_BRANCH=tmp/event-listener-debug
try

@ironman-machine
Copy link
Contributor

Hello @bennettbuchanan

"SCALITY_BACKBEAT_BRANCH=tmp/event-listener-debug": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/18432' with the following env. args:

{
    "SCALITY_ARSENAL_BRANCH": "bf/S3C-1134-streamLogConsumer",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.2",
    "SCALITY_BACKBEAT_BRANCH": "tmp/event-listener-debug",
    "DEFAULT_BRANCH": "rel/7.2",
    "REPO_NAME": "bucketclient",
    "SCALITY_BUCKETCLIENT_BRANCH": "bf/S3C-1134-streamGetRaftLog",
    "SCALITY_METADATA_BRANCH": "bf/S3C-1134-streamGetRaftLog"
}

@ironman-machine
Copy link
Contributor

💔 ☔ circleCI test failed.

@rahulreddy
Copy link
Collaborator

@ironman-machine
SCALITY_BACKBEAT_BRANCH=tmp/event-listener-debug
try

@ironman-machine
Copy link
Contributor

Hello @rahulreddy

"SCALITY_BACKBEAT_BRANCH=tmp/event-listener-debug": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/18436' with the following env. args:

{
    "SCALITY_ARSENAL_BRANCH": "bf/S3C-1134-streamLogConsumer",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.2",
    "SCALITY_BACKBEAT_BRANCH": "tmp/event-listener-debug",
    "DEFAULT_BRANCH": "rel/7.2",
    "REPO_NAME": "bucketclient",
    "SCALITY_BUCKETCLIENT_BRANCH": "bf/S3C-1134-streamGetRaftLog",
    "SCALITY_METADATA_BRANCH": "bf/S3C-1134-streamGetRaftLog"
}

@ironman-machine
Copy link
Contributor

💔 ⌛ circleCI test timed out...

@bennettbuchanan
Copy link

@ironman-machine
SCALITY_BACKBEAT_BRANCH=fix/S3C-1134
try

@ironman-machine
Copy link
Contributor

Hello @bennettbuchanan

"SCALITY_BACKBEAT_BRANCH=fix/S3C-1134": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/18447' with the following env. args:

{
    "SCALITY_ARSENAL_BRANCH": "bf/S3C-1134-streamLogConsumer",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.2",
    "SCALITY_BACKBEAT_BRANCH": "fix/S3C-1134",
    "DEFAULT_BRANCH": "rel/7.2",
    "REPO_NAME": "bucketclient",
    "SCALITY_BUCKETCLIENT_BRANCH": "bf/S3C-1134-streamGetRaftLog",
    "SCALITY_METADATA_BRANCH": "bf/S3C-1134-streamGetRaftLog"
}

@jonathan-gramain
Copy link
Contributor Author

@ironman-machine
SCALITY_BACKBEAT_BRANCH=bf/S3C-1134-streamLogConsumer
try

@ironman-machine
Copy link
Contributor

Hello @jonathan-gramain

"SCALITY_BACKBEAT_BRANCH=bf/S3C-1134-streamLogConsumer": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/18720' with the following env. args:

{
    "SCALITY_ARSENAL_BRANCH": "bf/S3C-1134-streamLogConsumer",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.2",
    "SCALITY_BACKBEAT_BRANCH": "bf/S3C-1134-streamLogConsumer",
    "DEFAULT_BRANCH": "rel/7.2",
    "REPO_NAME": "bucketclient",
    "SCALITY_BUCKETCLIENT_BRANCH": "bf/S3C-1134-streamGetRaftLog",
    "SCALITY_METADATA_BRANCH": "bf/S3C-1134-streamGetRaftLog"
}

@jonathan-gramain
Copy link
Contributor Author

@ironman-machine try

@ironman-machine
Copy link
Contributor

Hello @jonathan-gramain

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/18726' with the following env. args:

{
    "SCALITY_ARSENAL_BRANCH": "bf/S3C-1134-streamLogConsumer",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.2",
    "SCALITY_BACKBEAT_BRANCH": "bf/S3C-1134-streamLogConsumer",
    "DEFAULT_BRANCH": "rel/7.2",
    "REPO_NAME": "bucketclient",
    "SCALITY_BUCKETCLIENT_BRANCH": "bf/S3C-1134-streamGetRaftLog",
    "SCALITY_METADATA_BRANCH": "bf/S3C-1134-streamGetRaftLog"
}

@jonathan-gramain jonathan-gramain mentioned this pull request Jan 16, 2018
Merged
@jonathan-gramain
Copy link
Contributor Author

Integration passed in http://ci.ironmann.io/gh/scality/Integration/18729

A new PR is required in backbeat: scality/backbeat#169 (can be merged by itself first once tests pass).

@rahulreddy
Copy link
Collaborator

@ironman-machine
clean
after=scality/Arsenal#379
r+

@ironman-machine
Copy link
Contributor

Hello @rahulreddy

"clean": Success
"after=scality/Arsenal#379": Success
"r+": Success

@ironman-machine
Copy link
Contributor

One dependency hasn't been merged yet

@rahulreddy
Copy link
Collaborator

@ironman-machine r- r+

@ironman-machine
Copy link
Contributor

Hello @rahulreddy

"r-": Success
"r+": Success

@ironman-machine
Copy link
Contributor

⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/18758

@ironman-machine
Copy link
Contributor

⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/18759

@ironman-machine
Copy link
Contributor

💔 ☔ circleCI test failed.

@rahulreddy
Copy link
Collaborator

@ironman-machine r+

@ironman-machine
Copy link
Contributor

Hello @rahulreddy

"r+": Success

@ironman-machine
Copy link
Contributor

⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/18762

@ironman-machine ironman-machine merged commit 2a16b8e into rel/7.2 Jan 17, 2018
ironman-machine added a commit that referenced this pull request Jan 17, 2018
@ironman-machine
merge #126
b0836dc
@ironman-machine
Copy link
Contributor

☀️ 👍 circleCI test succeeded!

@ironman-machine ironman-machine deleted the bf/S3C-1134-streamGetRaftLog branch January 17, 2018 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamphamsy lamphamsy lamphamsy left review comments

@electrachong electrachong electrachong approved these changes

@ThibaultRiviere ThibaultRiviere ThibaultRiviere approved these changes

@MathieuCassagne MathieuCassagne MathieuCassagne approved these changes

@rahulreddy rahulreddy rahulreddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jonathan-gramain @ironman-machine @ThibaultRiviere @rahulreddy @bennettbuchanan @lamphamsy @MathieuCassagne @electrachong