bf: stream response from getRaftLog() #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-gramain
force-pushed
the
bf/S3C-1134-streamLogConsumer
branch
from
0cf746d
to
a1e6eb0
Compare
|
PR has been updated. Reviewers, please be cautious. |
|
electrachong
approved these changes
Dec 7, 2017
philipyoo
approved these changes
Dec 13, 2017
ThibaultRiviere
approved these changes
Dec 13, 2017
Adapt LogConsumer.readRecords() to use the stream returned by the modified BucketClient.getRaftLog() function. That allows end-to-end streaming, hence supporting arbitrary-sized responses, which should avoid toString() exceptions or consume excessive amounts of memory.
bennettbuchanan
force-pushed
the
bf/S3C-1134-streamLogConsumer
branch
from
a1e6eb0
to
6992222
Compare
rahulreddy
approved these changes
Jan 16, 2018
|
@ironman-machine |
|
Hello @rahulreddy "SCALITY_BUCKETCLIENT_BRANCH=bf/S3C-1134-streamGetRaftLog": Success |
|
⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/18755 |
|
☀️ 👍 circleCI test succeeded! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt LogConsumer.readRecords() to use the stream returned by the modified
BucketClient.getRaftLog() function. That allows end-to-end streaming, hence
supporting arbitrary-sized responses, which should avoid toString() exceptions
or consume excessive amounts of memory.
Goes with scality/bucketclient#126