Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARSN-368:Id and principal on policy hotfix #2174

Merged
merged 3 commits into from
Oct 2, 2023
Merged

ARSN-368:Id and principal on policy hotfix #2174

merged 3 commits into from
Oct 2, 2023

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Oct 2, 2023 •
edited
Loading

Description

Motivation and context

This PR adds support of the Id definition on resource policy document and principal length restriction on both resource and user policy

Checklist

Add tests to cover the changes

existing tests modified to cover all changes

@benzekrimaha
ARSN-367:principal change on schema and test add
23ea2ba 
The maximum length should be 2048 characters
having 31 characters on the fixed length prefix
this explains the 2017 max limit put in the schema

(cherry picked from commit 73c6f41)
@benzekrimaha
ARSN-365:Id added on policy schema and validator
505ff8e 
Signed-off-by: Maha Benzekri <[email protected]>
(cherry picked from commit 9ea39c6)
@benzekrimaha
ARSN-368:Bump arsenal version
b30d1a2
@bert-e
Copy link
Contributor

bert-e commented Oct 2, 2023

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 2, 2023

Incorrect fix version

The Fix Version/s in issue ARSN-368 contains:

  • 7.10.43-1

  • 7.70.4-1

Considering where you are trying to merge, I expected to find at least:

  • 7.10.43.1

Please check the Fix Version/s of ARSN-368, or the target
branch of this pull request.

@benzekrimaha benzekrimaha changed the title Bugfix/arsn 368 id and principal on policyhotfix ARSN-368:Id and principal on policy hotfix Oct 2, 2023
@benzekrimaha
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Oct 2, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha marked this pull request as ready for review October 2, 2023 14:01
@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Oct 2, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ hotfix/7.10.43

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 2, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/7.10.43

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-368.

Goodbye benzekrimaha.

@bert-e bert-e merged commit b30d1a2 into hotfix/7.10.43 Oct 2, 2023
4 checks passed
@bert-e bert-e deleted the bugfix/ARSN-368-id-and-principal-on-policyhotfix branch October 2, 2023 14:02
This was referenced Oct 2, 2023
Merged
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamlardier williamlardier williamlardier approved these changes

@nicolas2bert nicolas2bert nicolas2bert approved these changes

@TeddyAndrieux TeddyAndrieux Awaiting requested review from TeddyAndrieux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benzekrimaha @bert-e @nicolas2bert @williamlardier