Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rename resources #231

Merged
merged 9 commits into from
Aug 29, 2019
Merged

feat: rename resources #231

merged 9 commits into from
Aug 29, 2019

Conversation

QuentinBrosse
Copy link
Contributor

@QuentinBrosse QuentinBrosse commented Aug 28, 2019 •
edited by kindermoumoute
Loading

cf #143

@ghost ghost added size/M documentation and removed size/M labels Aug 28, 2019
@QuentinBrosse QuentinBrosse changed the title feat: resource_compute_instance_ip to resource_instance_ip feat: rename resources Aug 28, 2019
@ghost ghost added size/XL and removed size/L labels Aug 28, 2019
kindermoumoute
kindermoumoute approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBrosse QuentinBrosse merged commit e389a1e into scaleway:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuentinBrosse @kindermoumoute