Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recode all current resources following this scheme #143

Closed
11 tasks done
QuentinBrosse opened this issue Jun 5, 2019 · 7 comments
Closed
11 tasks done

Recode all current resources following this scheme #143

QuentinBrosse opened this issue Jun 5, 2019 · 7 comments
Milestone

Comments

@QuentinBrosse
Copy link
Contributor

QuentinBrosse commented Jun 5, 2019

Rename all current resources following this scheme :

scaleway_{namespace}_{product}_{resource}

The old resources will be kept but deprecated. This will allow the creation of resources for our new products.

Ressources

Storage

Compute

MISC

@QuentinBrosse QuentinBrosse mentioned this issue Jun 5, 2019
17 tasks
@QuentinBrosse QuentinBrosse added this to the v1.11.0 milestone Jun 5, 2019
@QuentinBrosse QuentinBrosse changed the title Rename all current resources following this scheme Recode all current resources following this scheme Jun 7, 2019
@abitrolly
Copy link

This will make Terraform files more verbose. What kind of servers are expected to make sense of additional namespace information in scaleway_compute_instance_server ?

@QuentinBrosse
Copy link
Contributor Author

Hi @abitrolly,

Our provider will support more products in the near future, that's why weed need to namespace our resources. Example of another type of server who will arrive soon: scaleway_compute_baremetal_server. :)

@abitrolly
Copy link

That makes sense, yes. ) Although I would leave it as scaleway_baremetal vs scaleway_server vs scaleway_container (for kubernetes).

@QuentinBrosse
Copy link
Contributor Author

We prefer to be a bit more explicit with this consistent scheme: scaleway_{category}_{productName}_{resourceName}.

You are right, it's a bit more verbose but it has the advantage to don't leave room for ambiguity.

@abitrolly
Copy link

If Python puts readability first, because people read code more often than write, then for Terraform it is even more important, because you have to type resource names in command line quite often too. At least I had to type "aws_instance" a few times a month on my previous job. Now I will need to remember "scaleway_compute_instance_server", "scaleway_compute_instance" or whatever..

I think it is possible droping to "scaleway_compute_instance" and "scaleway_compute_baremetal", because "server" is to vague. DevOps could use more fine grained terminology already.

@QuentinBrosse
Copy link
Contributor Author

@abitrolly we are in reflexion to remove the product category from the resource name. The scaleway_{category}_{productName}_{resourceName} scheme could became scaleway_{productName}_{resourceName}..

It is not acted yet, but we are thinking about it.

@QuentinBrosse
Copy link
Contributor Author

@abitrolly we will do it: scaleway_{category}_{productName}_{resourceName} scheme became scaleway_{productName}_{resourceName}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants