Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added scaleway_storage_object_bucket resource #150

Merged
merged 13 commits into from
Jul 3, 2019
Merged

feat: added scaleway_storage_object_bucket resource #150

merged 13 commits into from
Jul 3, 2019

Conversation

DenBeke
Copy link
Contributor

@DenBeke DenBeke commented Jun 7, 2019

No description provided.

@ghost ghost added the size/XL label Jun 7, 2019
@DenBeke
Copy link
Contributor Author

DenBeke commented Jun 7, 2019

cfr. #153

QuentinBrosse
QuentinBrosse suggested changes Jun 7, 2019
View reviewed changes
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/provider.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket_test.go Outdated Show resolved Hide resolved
@QuentinBrosse
Copy link
Contributor

Remove WIP?

@DenBeke
Copy link
Contributor Author

DenBeke commented Jun 7, 2019

Remove WIP?

Yeps, I'll update the PR with your feedback and then it's "ready" for me.

kindermoumoute
kindermoumoute requested changes Jun 7, 2019
View reviewed changes
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket.go Outdated Show resolved Hide resolved
@DenBeke DenBeke force-pushed the resource/storage/object/bucket branch from ae35723 to 8d76d19 Compare June 7, 2019 15:44
@DenBeke DenBeke changed the title WIP: feat: added scaleway_storage_object_bucket resource feat: added scaleway_storage_object_bucket resource Jun 7, 2019
@DenBeke DenBeke force-pushed the resource/storage/object/bucket branch from 8bca249 to 732296f Compare June 20, 2019 14:36
@DenBeke DenBeke force-pushed the resource/storage/object/bucket branch from 732296f to df572a9 Compare June 26, 2019 12:14
@QuentinBrosse QuentinBrosse changed the title feat: added scaleway_storage_object_bucket resource WIP: feat: added scaleway_storage_object_bucket resource Jun 26, 2019
@DenBeke DenBeke changed the title WIP: feat: added scaleway_storage_object_bucket resource feat: added scaleway_storage_object_bucket resource Jun 28, 2019
kindermoumoute
kindermoumoute requested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase this PR (depencendies have been updated)

@QuentinBrosse QuentinBrosse mentioned this pull request Jul 2, 2019
Closed
11 tasks
kindermoumoute
kindermoumoute approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost added the dependencies label Jul 3, 2019
jerome-quere
jerome-quere suggested changes Jul 3, 2019
View reviewed changes
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/config.go Outdated Show resolved Hide resolved
scaleway/helpers.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket.go Show resolved Hide resolved
scaleway/resource_storage_object_bucket.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket_test.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket_test.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_bucket_test.go Outdated Show resolved Hide resolved
scaleway/resource_storage_object_helpers.go Outdated Show resolved Hide resolved
jerome-quere
jerome-quere approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jerome-quere jerome-quere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuentinBrosse
QuentinBrosse approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@QuentinBrosse QuentinBrosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerome-quere jerome-quere merged commit 5c91abc into scaleway:master Jul 3, 2019
@gmile
Copy link

gmile commented Nov 16, 2019

I am trying to import existing bucket into my tf state. How do I know the UUID of bucket?

@jerome-quere
Copy link
Contributor

jerome-quere commented Nov 18, 2019 •
edited
Loading

Hi @gmile

This is an issue on our side. Import should be done by bucket name.
I opened #321 to track progress, this fix should be included in the next release.

@remyleone remyleone added the object Object storage issues, bugs and feature requests label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerome-quere jerome-quere jerome-quere approved these changes

@QuentinBrosse QuentinBrosse QuentinBrosse approved these changes

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
dependencies object Object storage issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DenBeke @QuentinBrosse @gmile @jerome-quere @kindermoumoute @remyleone