Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow adding ssh keys via the API #45

Closed
petems opened this issue Mar 1, 2018 · 5 comments · Fixed by #47
Closed

Feature request: allow adding ssh keys via the API #45

petems opened this issue Mar 1, 2018 · 5 comments · Fixed by #47

Comments

@petems
Copy link

petems commented Mar 1, 2018

The provider currently has no way of adding SSH keys to your Scaleaway account.

Funnily enough, the official Scaleway docs don't have instructions, but there is this community post:

https://community.online.net/t/api-account-ssh-keys/582/2

curl --header 'Content-Type: application/json' \
  --header 'X-Auth-Token: <YOUR TOKEN>' \
  https://account.cloud.online.net/users/<YOUR USER ID> \
  -X PATCH \
  -d '{"ssh_public_keys": [{"key": <YOUR KEY>}, {"key": <YOUR SECOND KEY>}]}'
@petems
Copy link
Author

petems commented Mar 1, 2018

As @paddycarver recommends, it would make sense to wait until this is officially documented to implement, as otherwise we'd end up in a situation supporting something that hasn't been officially "blessed" as a documented method.

@nicolai86
Copy link
Contributor

I think this would make a great addition to the provider!

@petems
Copy link
Author

petems commented Mar 1, 2018

I've reached out via a support ticket and their slack, hopefully I can get a response.

I might hack on trying to implement, then we can put a blocker on it until there's official docs.

@nicolai86
Copy link
Contributor

please add the SDK part as a PR to https://github.com/nicolai86/scaleway-sdk, as that's the Scaleway SDK in use here.

@petems
Copy link
Author

petems commented Mar 1, 2018

Oh cool, looks like it's already implemented:

https://github.com/nicolai86/scaleway-sdk/blob/master/user.go#L65

nicolai86 added a commit that referenced this issue Mar 15, 2018
preparation to implement #45
nicolai86 added a commit that referenced this issue Mar 15, 2018
nicolai86 added a commit that referenced this issue Mar 15, 2018
nicolai86 added a commit that referenced this issue Mar 15, 2018
nicolai86 added a commit that referenced this issue Mar 15, 2018
nicolai86 added a commit that referenced this issue Mar 15, 2018
nicolai86 added a commit that referenced this issue Mar 15, 2018
nicolai86 added a commit that referenced this issue Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants