add support for managing ssh keys #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolai86
force-pushed
the
ssh-keys
branch
3 times, most recently
from
1bdec44 to
941242d
Compare
tombuildsstuff
approved these changes
Mar 15, 2018
scaleway/resource_ssh_key.go
Outdated
| return nil | ||
| } | ||
|
|
||
| mu.Lock() |
There was a problem hiding this comment.
do you want to move this lock up / re-retrieve the list post-lock, in-case a secondary key gets added in the meantime?
scaleway/resource_ssh_key.go
Outdated
| }) | ||
| } | ||
| } | ||
| mu.Lock() |
There was a problem hiding this comment.
again - do we want to move this lock up?
| var testAccCheckScalewaySSHKeyConfig = ` | ||
| resource "scaleway_ssh_key" "test" { | ||
| key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDYpDmIzRs5c+xs0jmljMbNYVcgV8fRruMCRDA4HKjGN2lqLTZhngGDXsdt/2kTNQQPAq2sR4N8mfX5wMRT/+jNb+8esPyY5WlElni0zmD7oLoPW4lYRES6f7EeAv6NttLfkDO42r15OtMnglcgWk1u4o3lOXuLbhzJT1qdicpDja22X3uR/xUy1AYhKBOoiSlQbkb7NhL0lA1xQNwerdaJJS8tFB+wViVDyP0f1HaIRxViFlTGuTbTuIJNR/7VJ9VBBuTnYXaRkPxz64sUXrtdVK8U0+4KsisyXwmgQKnvZBDj91wxz12OOzFSQ52iFprIj1JbkzuBmNWXUGKYzXJZ test" | ||
| } |
There was a problem hiding this comment.
given the comments above, it might be worth a test adding multiple keys?
There was a problem hiding this comment.
added testcases for multiple keys including removal.
| }, | ||
| { | ||
| "checksumSHA1": "hfABw6DX9B4Ma+88qDDGz9qY45s=", | ||
| "path": "golang.org/x/crypto/internal/chacha20", |
There was a problem hiding this comment.
assuming go build is happy with the internal vendors :)
nicolai86
force-pushed
the
ssh-keys
branch
2 times, most recently
from
1bdb2f5 to
ac04d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for managing user ssh keys on scaleway.
the new resource looks like this:
The implementation relies on
golang.org/x/crypto/sshto parse the SSH key to retrieve the correct fingerprint; also included are docs.SSH keys can be imported like this:
closes #45