Added Tutorials to Docs #7095
Merged
Added Tutorials to Docs #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
daniel-wer
reviewed
May 24, 2023
There was a problem hiding this comment.
Nice, I mainly added comment for some minor issues. I wasn't able to render the docs to check the result, because of the poetry version issue (see scalableminds/webknossos-libs#905 (comment))
docs/sharing.md
Outdated
Comment on lines
179
to
206
| }, | ||
| mappingInfo?: { | ||
| mappingName: string, | ||
| mappingType: MappingType, | ||
| agglomerateIdsToImport?: Array<number>, | ||
| }, | ||
| connectomeInfo?: { | ||
| connectomeName: string, | ||
| agglomerateIdsToImport?: Array<number>, | ||
| }, | ||
| isDisabled?: boolean, | ||
| }, | ||
| }; | ||
|
|
||
| type UrlManagerState = {| | ||
| position?: Vector3, | ||
| mode?: ViewMode, | ||
| zoomStep?: number, | ||
| activeNode?: number, | ||
| rotation?: Vector3, | ||
| stateByLayer?: UrlStateByLayer, | ||
| |}; | ||
|
|
||
| ``` | ||
| type BaseMeshUrlDescriptor = {| | ||
| +segmentId: number, | ||
| +seedPosition: Vector3, | ||
| |}; | ||
| type AdHocMeshUrlDescriptor = {| | ||
| ...BaseMeshUrlDescriptor, | ||
| +isPrecomputed: false, | ||
| mappingName: ?string, | ||
| mappingType: ?MappingType, | ||
| |}; | ||
| type PrecomputedMeshUrlDescriptor = {| | ||
| ...BaseMeshUrlDescriptor, | ||
| +isPrecomputed: true, | ||
| meshFileName: string, | ||
| |}; | ||
| type MeshUrlDescriptor = AdHocMeshUrlDescriptor | PrecomputedMeshUrlDescriptor; | ||
|
|
||
| type UrlStateByLayer = { | ||
| [layerName: string]: { | ||
| meshInfo?: { | ||
| meshFileName: ?string, | ||
| meshes: Array<MeshUrlDescriptor>, | ||
| }, | ||
| mappingInfo?: { | ||
| mappingName: string, | ||
| mappingType: MappingType, | ||
| agglomerateIdsToImport?: Array<number>, | ||
| }, | ||
| connectomeInfo?: { | ||
| connectomeName: string, | ||
| agglomerateIdsToImport?: Array<number>, | ||
| }, | ||
| isDisabled?: boolean, | ||
| }, | ||
| }; | ||
|
|
||
| type UrlManagerState = {| | ||
| position?: Vector3, | ||
| mode?: ViewMode, | ||
| zoomStep?: number, | ||
| activeNode?: number, | ||
| rotation?: Vector3, | ||
| stateByLayer?: UrlStateByLayer, | ||
| |}; | ||
|
|
||
| ``` |
There was a problem hiding this comment.
This should be reverted, looks like your auto-formatter simply removed all indentation 🤷
Co-authored-by: Daniel <[email protected]>
Co-authored-by: Daniel <[email protected]>
daniel-wer
approved these changes
May 25, 2023
Co-authored-by: Daniel <[email protected]>
hotzenklotz
added a commit
that referenced
this pull request
May 31, 2023
…ty-list-drawings * 'master' of github.com:scalableminds/webknossos: [Docs] Update embedded YouTube URLs (#7102) Show organization in dataset info tab (#7087) Added Tutorials to Docs (#7095) Combine both download modals into one (#7068) Add "merge" blend mode (#6936) Changed the spacing/width of VX reports runs selection (#7094) Allow dataset managers to see all workflow reports of their orga (#7081) Fix rectangle at 0,0,0 (#7088) Allow to disable automatic reloading of meshes during proofreading (#7076)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two of the extended tutorials from Medium to the docs:
I uploaded the videos assets to S3
This PR requires an update the video plugins for mkdocs in the libs repo. scalableminds/webknossos-libs#905
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)