-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable automatic reloading of meshes during proofreading #7076
Allow to disable automatic reloading of meshes during proofreading #7076
Conversation
works great 👍 but design-wise, I would prefer a button which can be toggled. See my other PR where I did something similar in the toolbar: Also see this slack discussion about that decision if you are interested. |
@philippotto I thought your code concerning the button styling from the mentioned PR was very useful. is there any way to incorporate it into my code while keeping you as the author? Other than that I addressed your review thus far :) |
Great 👍 Two small things:
That's very kind of you, but there's no need for it :) In the end, the commits of the PR are squashed anyway and you will be listed as the main author. Also, we don't really track statistics about commit authors, so it doesn't really matter in the end (: |
I left the opacity out because it felt more like an adjustment if the button was disabled. I will add it back in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you :)
@philippotto I felt like the merge conflicts were non-trivial. My new button is still working as expected, but could you check whether I destroyed any functionality of your auto-select SAM PR (or anything else)? |
The changes look good :) Feel free to merge! |
…ty-list-drawings * 'master' of github.com:scalableminds/webknossos: [Docs] Update embedded YouTube URLs (#7102) Show organization in dataset info tab (#7087) Added Tutorials to Docs (#7095) Combine both download modals into one (#7068) Add "merge" blend mode (#6936) Changed the spacing/width of VX reports runs selection (#7094) Allow dataset managers to see all workflow reports of their orga (#7081) Fix rectangle at 0,0,0 (#7088) Allow to disable automatic reloading of meshes during proofreading (#7076)
Steps to test:
Issue: