Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more drawings and rebranding to UI #6938

Merged
merged 19 commits into from
Apr 4, 2023
Merged

Added more drawings and rebranding to UI #6938

merged 19 commits into from
Apr 4, 2023

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Mar 22, 2023

This PR adds more icons & drawings and rebranding to various pages within the UI

Changes:

  • Applied 404 page rebranding
  • Applied Paid Feature not available page rebranding
  • Applied login page rebranding with little welcome guy
  • Applied registration page rebranding with little welcome guy
  • Applied registration page page rebranding also the RegistrationPageDemo page which was forgotten the last time around
  • Renamed RegistrationFormDemo to RegistrationFormWKOrg to avoid confusion
  • Removed all references to word spotlight. Renamed CSS classes, files and JS Components accordingly

URL of deployed dev instance (used for testing):

Steps to test:

  • Click through all the mentioned pages above and check if styling looks correct
  • Try screen resizing? Try Light/Dark Theme

Issues:


(Please delete unneeded items, merge only when none are left open)

…wings

* 'master' of github.com:scalableminds/webknossos:
  Update screenshots (#6934)
  Support rendering negative floats (#6895)
  Fix loading of webworkers in dev mode (#6933)
  Restore cache buster for webworkers (#6932)
  Introduce data vault as storage backend abstraction (#6899)
  Fix download button for annotations when tiff export is disabled (#6931)
  Update PULL_REQUEST_TEMPLATE.md
  Prepare multi modality support (#6748)
  Improvements for terms-of-services modal (#6930)
  Fix creating task types with preferred mode (#6928)
@hotzenklotz hotzenklotz self-assigned this Mar 22, 2023
@hotzenklotz hotzenklotz added the UX label Mar 23, 2023
@hotzenklotz hotzenklotz changed the title Added more icons & drawings to UI Added more drawings and rebranding to UI Mar 23, 2023
@hotzenklotz hotzenklotz requested a review from philippotto March 23, 2023 12:27
@hotzenklotz hotzenklotz marked this pull request as ready for review March 23, 2023 12:30
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole file was just renamed and I renamed CSS class .spotlight-item-card to .publication-item-card. No further changes.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool changes! Only see my one comment before merging.

// SpotlightRegistrationForm always creates a new organization. If an inviteToken
// exists, a normal RegistrationForm needs to be used.
// RegistrationFormWKOrg always creates a new organization. If an inviteToken
// exists, a normal RegistrationFormGeneric needs to be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 47 uses RegistrationForm, though?

…wings

* 'master' of github.com:scalableminds/webknossos:
  updates docs for docker installation (#6963)
  Fix misc stuff when viewing tasks/annotations of another user (#6957)
  Remove segment from list and add undo/redo for segments (#6944)
  Log all details on deleting annotation layer (#6950)
  fix typo
  Rename demo instance to wkorg instance (#6941)
  Add LOD mesh support for frontend (#6909)
  Fix layout of view mode switcher and move it (#6949)
  VaultPath no longer extends nio.Path (#6942)
  Release 23.04.0 (#6945)
  Use new zip.js version to allow zip64 uploads (#6939)
  Implement viewing sharded neuroglancer precomputed datasets (#6920)
  Reject dataset uploads if organization storage quota is exceeded (#6893)
  Refactor deprecated antd Dropdown menus (#6898)
@hotzenklotz hotzenklotz merged commit e4d7860 into master Apr 4, 2023
@hotzenklotz hotzenklotz deleted the drawings branch April 4, 2023 13:39
hotzenklotz added a commit that referenced this pull request Apr 4, 2023
…come-toast

* 'master' of github.com:scalableminds/webknossos:
  Added more drawings and rebranding to UI (#6938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants