Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating task types with preferred mode #6928

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix creating task types with preferred mode #6928

merged 1 commit into from
Mar 20, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 20, 2023

This field did not yet use the enum type but instead was string.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create a task type with and without a selected “preferred mode” each
  • Check that you can list both task types in the task types table

@fm3 fm3 requested a review from normanrz March 20, 2023 09:09
@fm3 fm3 self-assigned this Mar 20, 2023
@fm3 fm3 enabled auto-merge (squash) March 20, 2023 09:10
@fm3 fm3 merged commit 11ab167 into master Mar 20, 2023
@fm3 fm3 deleted the fix-task-type-creation branch March 20, 2023 09:26
hotzenklotz added a commit that referenced this pull request Mar 20, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into ema…
0424034 
…il-notification

* 'master' of github.com:scalableminds/webknossos:
  Prepare multi modality support (#6748)
  Improvements for terms-of-services modal (#6930)
  Fix creating task types with preferred mode (#6928)
hotzenklotz added a commit that referenced this pull request Mar 20, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into dro…
0879f2e 
…pdown-menu

* 'master' of github.com:scalableminds/webknossos:
  Fix download button for annotations when tiff export is disabled (#6931)
  Update PULL_REQUEST_TEMPLATE.md
  Prepare multi modality support (#6748)
  Improvements for terms-of-services modal (#6930)
  Fix creating task types with preferred mode (#6928)
  Fix styling for login pages for dark mode users (#6916)
  Added members to admin team page (#6915)
  Release 23.03.1 (#6917)
  Redesign Welcome UI (#6904)
  Fix race condition which could disable saving (#6914)
hotzenklotz added a commit that referenced this pull request Mar 22, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into dra…
fc2477a 
…wings

* 'master' of github.com:scalableminds/webknossos:
  Update screenshots (#6934)
  Support rendering negative floats (#6895)
  Fix loading of webworkers in dev mode (#6933)
  Restore cache buster for webworkers (#6932)
  Introduce data vault as storage backend abstraction (#6899)
  Fix download button for annotations when tiff export is disabled (#6931)
  Update PULL_REQUEST_TEMPLATE.md
  Prepare multi modality support (#6748)
  Improvements for terms-of-services modal (#6930)
  Fix creating task types with preferred mode (#6928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @normanrz