Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Deactivating Organization Owner #6816

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Prevent Deactivating Organization Owner #6816

merged 1 commit into from
Feb 6, 2023

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 6, 2023

Prevents deactivating the (last) organization owner.

Also slipped in here: Skip unlisted users in annotation contributor list.

Steps to test:

  • Set up two admins, one of whom should be the organization owner
  • As the other admin, try to deactivate the owner from the user list view
  • Should be denied.
  • Set a user as unlisted, set an annotation to shared + multi-user editing, edit as the unlisted user, should not show up in contributors list in annotation view right sidebar

Issues:

  • Ready for review

@fm3 fm3 requested a review from jstriebel February 6, 2023 09:27
@fm3 fm3 self-assigned this Feb 6, 2023
@philippotto philippotto changed the title Prevent Deactivaing Organization Owner Prevent Deactivating Organization Owner Feb 6, 2023
jstriebel
jstriebel approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 merged commit c9c481b into master Feb 6, 2023
@fm3 fm3 deleted the prevent-zero-owners branch February 6, 2023 10:09
hotzenklotz added a commit that referenced this pull request Feb 6, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into org…
b04de23 
…a_owner

* 'master' of github.com:scalableminds/webknossos:
  Fix saving allowed teams in dataset settings (#6817)
  Prevent Deactivaing Orga Owner (#6816)
  Fix some login problems (#6810)
hotzenklotz added a commit that referenced this pull request Feb 7, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into fix…
b1a2f0b 
…_editable_text_style

* 'master' of github.com:scalableminds/webknossos:
  Rewrite database tooling and support for postgres passwords (#6803)
  Fix saving allowed teams in dataset settings (#6817)
  Prevent Deactivaing Orga Owner (#6816)
  Fix some login problems (#6810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

Assignees

@fm3 fm3

Labels
backend enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prevent deactivating organization owner Filter unlisted users from annotation contributor list
2 participants
@fm3 @jstriebel