Rewrite database tooling and support for postgres passwords #6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ftr https://stackoverflow.com/posts/70103077/revisions to change the owner of postgres objects. |
philippotto
reviewed
Feb 2, 2023
Co-authored-by: Florian M <[email protected]> Co-authored-by: Philipp Otto <[email protected]>
philippotto
approved these changes
Feb 2, 2023
hotzenklotz
added a commit
that referenced
this pull request
Feb 6, 2023
…a_owner * 'master' of github.com:scalableminds/webknossos: Rewrite database tooling and support for postgres passwords (#6803)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the previous database tools from
tools/postgresinto a single JS file with multiple commands. Thedbtool(I'll happily take other name suggestions) has some handling of parsing the Scala-supplied postgres connection config into regular postgres URLs (eg.postgres://user:password@host:port/database) for use withpsql.The Scala code now calls this tool by invoking node as a command instead of JVM-executed JS. Therefore, I added node to the Docker image. I could remove a few Scala and node dependencies.
diff-schemawas a JS script already, but I also rewrote to have everything in one place. I tested that it produces exactly the same dump output.To test everything, I configured the CI to use non-standard user/password combination and set up a different postgres user on the dev instance.
URL of deployed dev instance (used for testing):
Steps to test:
CREATE ROLE webknossos WITH LOGIN SUPERUSER PASSWORD '...';slick.conf(or as env var)tools/postgres/dbtool.js; although, most are checked during runtime or CIIssues:
(Please delete unneeded items, merge only when none are left open)