-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proofreading without skeletons #6625
Conversation
…ofreading-without-skeletons
This reverts commit b37134e.
…ofreading-without-skeletons
…increase opacity of active segment
…ofreading-without-skeletons
frontend/javascripts/oxalis/controller/combinations/bounding_box_handlers.ts
Show resolved
Hide resolved
Great work 👍 Feels already pretty good! See my comments about the overloading of the left-click. During testing, I clicked on a node which was weird, because the proofreading position was set to the click position, but afterwards the z-coordinate was changed to the node (due to clipping distance > 1). Therefore, I couldn't see the crosshair, anymore. |
frontend/javascripts/oxalis/controller/combinations/bounding_box_handlers.ts
Show resolved
Hide resolved
frontend/javascripts/oxalis/geometries/materials/plane_material_factory.ts
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/geometries/materials/plane_material_factory.ts
Outdated
Show resolved
Hide resolved
…ofreading-without-skeletons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent 💯 Also thank you for fixing the quick select geometry at 0,0,0 🙏
I'll merge this on Monday in case anything goes wrong :) |
Allow to proofread by clicking on segments instead of agglomerate skeleton nodes.
The position of the active segment is now updated when clicking onto a segment and also highlighted in proofreading mode using a small white cross hair. Afterwards, users can right-click somewhere else and select the entry to split or merge (a) segment(s).
Additionally, the active segment is highlighted a bit more than the currently hovered segment to make it more prominent and more easily recognizable.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)