Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading without skeletons #6625

Merged
merged 20 commits into from
Nov 21, 2022
Merged

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Nov 9, 2022

Allow to proofread by clicking on segments instead of agglomerate skeleton nodes.
The position of the active segment is now updated when clicking onto a segment and also highlighted in proofreading mode using a small white cross hair. Afterwards, users can right-click somewhere else and select the entry to split or merge (a) segment(s).
Additionally, the active segment is highlighted a bit more than the currently hovered segment to make it more prominent and more easily recognizable.

URL of deployed dev instance (used for testing):

Steps to test:

  • Create an annotation, activate an agglomerate view mapping and select the proofreading tool
    • Click on some segments - the click position should be highlighted with a zoom-independent cross hair + the active segment should be highlighted with higher opacity
    • Right-click somewhere else and select "Merge with active Segment" or "Split from active Segment"
  • Open datasets with different scales - the cross hair should always have the same size.
  • Use "Shift + Leftclick" and "Ctrl + Leftclick" to merge/split segments without the context menu. The description in the bottom bar should adapt automatically.
  • Loading agglomerate skeletons and deleting/adding edges should still work for proofreading, although it's less discoverable (by design, might be removed in the near future)

Issues:


(Please delete unneeded items, merge only when none are left open)

@daniel-wer daniel-wer self-assigned this Nov 9, 2022
@daniel-wer daniel-wer changed the title [WIP] Proofreading without skeletons Proofreading without skeletons Nov 14, 2022
@philippotto
Copy link
Member

Great work 👍 Feels already pretty good! See my comments about the overloading of the left-click. During testing, I clicked on a node which was weird, because the proofreading position was set to the click position, but afterwards the z-coordinate was changed to the node (due to clipping distance > 1). Therefore, I couldn't see the crosshair, anymore.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 💯 Also thank you for fixing the quick select geometry at 0,0,0 🙏

@daniel-wer
Copy link
Member Author

I'll merge this on Monday in case anything goes wrong :)

@daniel-wer daniel-wer merged commit f60759a into master Nov 21, 2022
@daniel-wer daniel-wer deleted the proofreading-without-skeletons branch November 21, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proofreading] Make agglomerate skeletons unnecessary
2 participants