Update immutability-helper package to v3.1.1 with TS support #6565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotzenklotz
added a commit
that referenced
this pull request
Oct 19, 2022
…ault_volume_layer * 'master' of github.com:scalableminds/webknossos: (21 commits) adds ETA calculation to voxelytics tasks (#6564) update immutability-helper package to v3.1.1 with TS support (#6565) [Skeletons] Allow deletion of root group (#6553) fix disappearing sidebar button (#6555) Enable "What's new" in navbar for everybody (#6563) Highlight Menu in Navbar Menu (#6558) refactor Select loading spinner property (#6556) Reload histogram when reloading layer (#6537) added more usage shortcuts to status bar (#6549) Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548) Add links to resource creation pages (#6513) Improve Zarr Import UI (and general editing of datasets) (#6485) Remove unused dataSetName and organizationName property of protobuf objects (#6559) WIP: Added manual task assignment (#6551) Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541) Fix stack overflow in compactMovedNodesAndEdges (#6557) Add backspace keyboard shortcut to delete active node (#6554) fix scaling in new meshfile rendering (#6552) Added more filters and sorting options to Projects list (#6550) fix double occurance of "ago" in VX progress times (#6535) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @philippotto suggestion, I updated the immutability-helper package to v3.1.1. The updated package has been re-written in Typescript and hopefully should provide better type coverage.
@philippotto and I did a quick spot check in some reducers and were pleased that we were given proper type errors :-)
I ran the TS type coverage reporter (
yarn ts-coverage) but that did not report any differences betweenmasterand this PR. 🤷Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)