Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight Menu in Navbar Menu #6558

Merged
merged 7 commits into from
Oct 18, 2022
Merged

Highlight Menu in Navbar Menu #6558

merged 7 commits into from
Oct 18, 2022

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Oct 17, 2022 •
edited
Loading

During a discussion, we were left unsatisfied that the main navbar menu with many of the important dataset-wide actions items (Download, Sharing, Zarr Links) etc is very subtle / underrepresented:

  • In "View" mode, the menu is easily overlooked since it is just a down-facing arrow (next to a super prominent, primary-color toggle switch for the left-hand side panel).
  • In "Tracing Mode", the menu is also still tucked away next to the Save button and easily overlooked.

This PR proposed the following changes:

  • Make the menu a separate dropdown button with an explicit title to give it the space it deserves in both View and Tracing mode
  • Remove the cog icon, which on toggles the left-hand side bar. This is a legacy UI element and there are 2 alternative toggle buttons + a keyboard shortcut ("K") for that.

View Mode:
image

Tracing Mode:
image

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Open any dataset/annotation in both view and tracing modes

Issues:

  • No issue

(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz self-assigned this Oct 17, 2022
@philippotto
Copy link
Member

I'm in favor of these changes, but the word "Menu" seems weird to me. It's as if a button element would have "Button" as its content. can we find another word for it? suggestions:

  • More
  • Actions
  • Edit

I'm not super convinced of these, though.. "More" would be my top-pick now. Also refer:
image

I just found https://uxplanet.org/alternatives-of-hamburger-menu-a8b0459bf994 which also suggests "Menu". so, maybe it's fine in the end.

@fm3 maybe you also have an idea/opinion?

@fm3
Copy link
Member

fm3 commented Oct 18, 2022

@fm3 maybe you also have an idea/opinion?

I think “Menu” is acceptable as well, “Actions” or “More“ also works for me. I’m afraid I don’t really have another idea

@hotzenklotz hotzenklotz enabled auto-merge (squash) October 18, 2022 12:49
@hotzenklotz
Copy link
Member Author

@normanrz Do you have a opinion on that?

I am still in favor of "Menu" even so it is slightly generic. Yet, it is very much to the point, does not require any explanation and give users a clear idea of what might be behind the button.

@normanrz
Copy link
Member

I think "Menu" is good. "Actions" would also be fine. "More" would be missing a context imho.

@hotzenklotz hotzenklotz merged commit 8f67d58 into master Oct 18, 2022
@hotzenklotz hotzenklotz deleted the navbar_menu branch October 18, 2022 14:11
hotzenklotz added a commit that referenced this pull request Oct 19, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into def…
c72b8fa 
…ault_volume_layer

* 'master' of github.com:scalableminds/webknossos: (21 commits)
  adds ETA calculation to voxelytics tasks (#6564)
  update immutability-helper package to v3.1.1 with TS support (#6565)
  [Skeletons] Allow deletion of root group (#6553)
  fix disappearing sidebar button (#6555)
  Enable "What's new" in navbar for everybody (#6563)
  Highlight Menu in Navbar Menu (#6558)
  refactor Select loading spinner property (#6556)
  Reload histogram when reloading layer (#6537)
  added more usage shortcuts to status bar (#6549)
  Look up annotation dataset by tracing id instead of (broken) organizationName field (#6548)
  Add links to resource creation pages (#6513)
  Improve Zarr Import UI (and general editing of datasets) (#6485)
  Remove unused dataSetName and organizationName property of protobuf objects (#6559)
  WIP: Added manual task assignment (#6551)
  Fix zarr private links for volume tracings and some minor improvements to private links UI (#6541)
  Fix stack overflow in compactMovedNodesAndEdges (#6557)
  Add backspace keyboard shortcut to delete active node (#6554)
  fix scaling in new meshfile rendering (#6552)
  Added more filters and sorting options to Projects list (#6550)
  fix double occurance of "ago" in VX progress times (#6535)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

@philippotto philippotto Awaiting requested review from philippotto

Assignees

@hotzenklotz hotzenklotz

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hotzenklotz @philippotto @fm3 @normanrz