Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "shift + w" shortcut to cycle backwards through tools #6493

Merged
merged 5 commits into from
Sep 27, 2022

Conversation

Dagobert42
Copy link
Contributor

@Dagobert42 Dagobert42 commented Sep 26, 2022

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open an annotation and use shift + w to cycle through tools backwards

Issues:


(Please delete unneeded items, merge only when none are left open)

@Dagobert42 Dagobert42 changed the title Add shift w hotkey to cycle backwards through tools Add "shift + w" shortcut to cycle backwards through tools Sep 26, 2022
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Since "Shift" is also a modifier to temporarily switch from one tool to another, the preview is a bit weird (keeping shift pressed down will often show the color picker icon). However, I don't see a good way to circumvent this and also the switching itself works properly. So, let's go with it for now :)

@philippotto
Copy link
Member

Please also update the documentation here: https://github.com/scalableminds/webknossos/blob/master/docs/keyboard_shortcuts.md?plain=1#L103

Would be cool if you could also rename "toggle mode" to "cycle through tools" :)

@Dagobert42 Dagobert42 enabled auto-merge (squash) September 27, 2022 09:23
@Dagobert42 Dagobert42 merged commit a7e7239 into master Sep 27, 2022
@Dagobert42 Dagobert42 deleted the add-shift-w-to-cycle-tools-backwards branch September 27, 2022 09:43
hotzenklotz added a commit that referenced this pull request Oct 13, 2022
…jects-created

* 'master' of github.com:scalableminds/webknossos: (337 commits)
  Fix docs for the annotation download file format (#6546)
  Added total runtime information to VX reports (#6543)
  fix VX report for completed + skipped tasks (#6540)
  Avoid allocating spire uint objects during apply agglomerate (#6532)
  Explore remote N5 datasets (#6520)
  Fix MeshChunk byteOffset (Long, not Int) (#6536)
  update browserslist (#6505)
  Support new Mesh File (v3) (#6491)
  makes workflow_yamlContent optional (#6518)
  Always return 404 for Failures in Zarr Streaming (#6515)
  Poll wk version to notify during upgrade (#6451)
  add script which extracts newest changelog and creates GH release for it (#6504)
  release 22.10.0 (#6500)
  voxel³ -> voxel (#6501)
  Allow task type summary to identify task type when creating tasks in bulk (#6486)
  Fix sql evolution 090 (defer not null constraint) (#6498)
  SQL schema cleanup (#6492)
  Fix validation of layer selection when trying to start globalization of floodfills (#6497)
  Add "shift + w" shortcut to cycle backwards through tools (#6493)
  Fix filtering for public datasets in dataset table (#6496)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift+W could cycle current tool backwards
2 participants