Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL schema cleanup #6492

Merged
merged 6 commits into from
Sep 27, 2022
Merged

SQL schema cleanup #6492

merged 6 commits into from
Sep 27, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Sep 26, 2022 •
edited
Loading

Normalizes the sql schema a bit, adds missing foreign key constraint.

URL of deployed dev instance (used for testing):

Steps to test:

  • should still be able to manage/view datasets

Issues:

@fm3 fm3 self-assigned this Sep 26, 2022
@fm3 fm3 changed the title [WIP] sql schema cleanup SQL schema cleanup Sep 27, 2022
@fm3 fm3 marked this pull request as ready for review September 27, 2022 09:41
@fm3 fm3 requested a review from leowe September 27, 2022 09:43
leowe
leowe approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@leowe leowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fm3 fm3 enabled auto-merge (squash) September 27, 2022 11:29
@fm3 fm3 merged commit 0c27b83 into master Sep 27, 2022
@fm3 fm3 deleted the sql-cleanup branch September 27, 2022 11:29
hotzenklotz added a commit that referenced this pull request Oct 13, 2022
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into pro…
8810958 
…jects-created

* 'master' of github.com:scalableminds/webknossos: (337 commits)
  Fix docs for the annotation download file format (#6546)
  Added total runtime information to VX reports (#6543)
  fix VX report for completed + skipped tasks (#6540)
  Avoid allocating spire uint objects during apply agglomerate (#6532)
  Explore remote N5 datasets (#6520)
  Fix MeshChunk byteOffset (Long, not Int) (#6536)
  update browserslist (#6505)
  Support new Mesh File (v3) (#6491)
  makes workflow_yamlContent optional (#6518)
  Always return 404 for Failures in Zarr Streaming (#6515)
  Poll wk version to notify during upgrade (#6451)
  add script which extracts newest changelog and creates GH release for it (#6504)
  release 22.10.0 (#6500)
  voxel³ -> voxel (#6501)
  Allow task type summary to identify task type when creating tasks in bulk (#6486)
  Fix sql evolution 090 (defer not null constraint) (#6498)
  SQL schema cleanup (#6492)
  Fix validation of layer selection when trying to start globalization of floodfills (#6497)
  Add "shift + w" shortcut to cycle backwards through tools (#6493)
  Fix filtering for public datasets in dataset table (#6496)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leowe leowe leowe approved these changes

Assignees

@fm3 fm3

Labels
backend refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove default '' from id fields in sql schema jobs._dataStore should be VARCHAR instead of CHAR
2 participants
@fm3 @leowe