Change GET routes with side effects to POST #6023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstriebel
approved these changes
Feb 7, 2022
| @@ -22,6 +22,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released | |||
| - When changing which layers are visible in an annotation, this setting is persisted in the annotation, so when you share it, viewers will see the same visibility configuration. [#5967](https://github.com/scalableminds/webknossos/pull/5967) | |||
| - Downloading public annotations is now also allowed without being authenticated. [#6001](https://github.com/scalableminds/webknossos/pull/6001) | |||
| - Downloaded volume annotation layers no longer produce zero-byte zipfiles but rather a valid header-only zip file with no contents. [#6022](https://github.com/scalableminds/webknossos/pull/6022) | |||
| - Changed a number of API routes from GET to POST to avoid unwanted side effects. [#6023](https://github.com/scalableminds/webknossos/pull/6023) | |||
There was a problem hiding this comment.
Please also note that triggerInboxCheck was removed
hotzenklotz
added a commit
that referenced
this pull request
Feb 8, 2022
* 'master' of github.com:scalableminds/webknossos: Log legacy route usages (#6024) Change GET routes with side effects to POST (#6023) More api swagger annotations (#5989) add shorthand for deleting trees (#6013) Added shorthand to mark branch points from context menu (#6012) Map node group context menu to right-click (#6021) For empty volume tracings, serve header-only zip (#6022) use allDataBlocking and temporary files for explorative download (#6009)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing wk routes from GET to POST that have side effects, as described in #5988
Also removed unused route
checkInbox(without theBlocking)Note for reviewer: On the wk backend side I renamed the method
postWithJsonResponsetopostJsonWithJsonResponseto indicate that is indeed also sending data in the body. The new methodpostWithJsonResponsedoes not send data in the body.Steps to test:
Issues: