Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use allDataBlocking and temporary files for explorative download #6009

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 2, 2022

Changing the wk-backend-side handling of downloading single annotations (tasks + exploratives, not compound): ditching the stream forwarding in favor of what has proven stable for compound annotations already (see #3959). A negative side effect could be slightly longer response times, since the file is only served after it is completely written. Though if prevents the dataloss we sometimes saw previously, I think it is worth it.

URL of deployed dev instance (used for testing):

Steps to test:

  • create annotations + download them, check for expected content
    • skeleton-only
    • hybrid with one volume layer
    • hybrid with multiple volume layers

Issues:


@fm3 fm3 self-assigned this Feb 2, 2022
@fm3 fm3 requested a review from jstriebel February 2, 2022 13:13
@fm3 fm3 marked this pull request as ready for review February 2, 2022 13:13
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 👍 Thanks for the walk-through

@fm3 fm3 merged commit 50cef58 into master Feb 3, 2022
@fm3 fm3 deleted the volume-download-blocking branch February 3, 2022 06:50
hotzenklotz added a commit that referenced this pull request Feb 3, 2022
…up_menu

* 'master' of github.com:scalableminds/webknossos:
  use allDataBlocking and temporary files for explorative download (#6009)
hotzenklotz added a commit that referenced this pull request Feb 3, 2022
…nchpoints_shortcut

* 'master' of github.com:scalableminds/webknossos:
  use allDataBlocking and temporary files for explorative download (#6009)
hotzenklotz added a commit that referenced this pull request Feb 8, 2022
* 'master' of github.com:scalableminds/webknossos:
  Log legacy route usages (#6024)
  Change GET routes with side effects to POST (#6023)
  More api swagger annotations (#5989)
  add shorthand for deleting trees (#6013)
  Added shorthand to mark branch points from context menu (#6012)
  Map node group context menu to right-click (#6021)
  For empty volume tracings, serve header-only zip (#6022)
  use allDataBlocking and temporary files for explorative download (#6009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants