Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move /srv/webknossos to /webknossos in the dockerfiles #5843

Merged
merged 10 commits into from
Nov 17, 2021
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
- Added a new bounding box tool that allows resizing and creating bounding boxes more easily. Additionally, the context menu now contains options to modify the bounding box close to the clicked position. [#5767](https://github.com/scalableminds/webknossos/pull/5767)

### Changed
-
- The docker setup has been restructured, which requires changes to existing docker-compose setups. See the migration guide for details. [#5843](https://github.com/scalableminds/webknossos/pull/5843)

### Fixed
- Fixed a bug where admins could not share annotations with teams they were not explicitly a member of. [#5845](https://github.com/scalableminds/webknossos/pull/5845)
Expand Down
13 changes: 8 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
FROM openjdk:8-jdk
RUN apt-get update \
&& apt-get -y install postgresql-client \
&& rm -rf /var/lib/apt/lists/*
&& apt-get -y install postgresql-client \
&& rm -rf /var/lib/apt/lists/*

RUN mkdir -p /srv/webknossos
WORKDIR /srv/webknossos
RUN mkdir -p /webknossos
WORKDIR /webknossos

COPY target/universal/stage .
COPY webknossos-datastore/lib/native target/universal/stage/lib/native
Expand All @@ -17,6 +17,9 @@ RUN addgroup --system --gid 999 webknossos \
&& chmod go+x bin/webknossos \
&& chmod go+w .

RUN echo '#!/bin/bash\numask 002\nbin/webknossos "$@"\n' > /docker-entrypoint.sh \
&& chmod +x /docker-entrypoint.sh

HEALTHCHECK \
--interval=1m --timeout=5s --retries=10 \
CMD curl --fail http://localhost:9000/api/buildinfo || exit 1
Expand All @@ -25,4 +28,4 @@ USER webknossos

EXPOSE 9000

ENTRYPOINT [ "bin/webknossos" ]
ENTRYPOINT [ "/docker-entrypoint.sh" ]
3 changes: 2 additions & 1 deletion MIGRATIONS.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ User-facing changes are documented in the [changelog](CHANGELOG.released.md).

## Unreleased

-
- The docker files now place the webKnossos installation under `/webknossos` instead of `/srv/webknossos`. All mounts, most importantly `/srv/webknossos/binaryData`, need to be changed accordingly.
- The entrypoint of the docker files have changed. Therefore, any existing `docker-compose.yml` setups need to be adapted. In most cases, only the `entrypoint: bin/webknossos` lines need to be removed (if existant).

### Postgres Evolutions:

Expand Down
6 changes: 2 additions & 4 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ services:
# - -Dplay.modules.enabled-="com.scalableminds.webknossos.datastore.DataStoreModule"
# - -Dplay.http.router="noDS.Routes"
volumes:
- ./binaryData:/srv/webknossos/binaryData
- ./binaryData:/webknossos/binaryData
environment:
- POSTGRES_URL=jdbc:postgresql://postgres/webknossos
user: ${USER_UID:-1000}:${USER_GID:-1000}
Expand All @@ -42,9 +42,8 @@ services:
image: scalableminds/webknossos-datastore:${DOCKER_TAG:-master}
ports:
- "9090:9090"
entrypoint: bin/webknossos-datastore
volumes:
- ./binaryData:/srv/webknossos-datastore/binaryData
- ./binaryData:/webknossos-datastore/binaryData
command:
- -J-Xmx20G
- -J-Xms1G
Expand All @@ -58,7 +57,6 @@ services:
image: scalableminds/webknossos-tracingstore:${DOCKER_TAG:-master}
ports:
- "9050:9050"
entrypoint: bin/webknossos-tracingstore
command:
- -J-Xmx20G
- -J-Xms1G
Expand Down
2 changes: 1 addition & 1 deletion docs/datasets.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ services:
webknossos:
...
volumes:
- ./data:/srv/webknossos/binaryData
- ./data:/webknossos/binaryData
- /cluster:/cluster
...
```
Expand Down
22 changes: 0 additions & 22 deletions tools/binary_data/download_knossos_data.py

This file was deleted.

13 changes: 0 additions & 13 deletions tools/binary_data/generate_voronoi_cubes.py

This file was deleted.

139 changes: 0 additions & 139 deletions tools/binary_data/grabData.sh

This file was deleted.

112 changes: 0 additions & 112 deletions tools/binary_data/knossos_to_wkw.py

This file was deleted.

Loading