move /srv/webknossos to /webknossos in the dockerfiles #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable to me 👍 |
fm3
reviewed
Nov 15, 2021
jstriebel
reviewed
Nov 17, 2021
There was a problem hiding this comment.
Nice! I mostly added one suggestion to keep the bin/webknossos call part of the entrypoint, which allows to keep the current commands as they are.
Unfortunately, this brings a migration burden, where all mount-configs need to be changed. Would love to hear your feedback on that.
I think that's fine 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the webKnossos files in the docker container from
/srv/webknossosto/webknossos. This will make deployment on our infrastructure much easier, because we can mount/srvwholly and all symlinks etc will work internally.Unfortunately, this brings a migration burden, where all mount-configs need to be changed. Would love to hear your feedback on that.
This PR also cleans up some unused and probably out-of-date scripts.