-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of movements in 3rd dimension #5801
Conversation
// todo: remove | ||
console.log({ moveDistanceIn1Second, passedFraction }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// todo: remove | |
console.log({ moveDistanceIn1Second, passedFraction }); |
frontend/javascripts/oxalis/view/action-bar/dataset_position_view.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/action-bar/dataset_position_view.js
Outdated
Show resolved
Hide resolved
@fm3 Feel free to check out https://fixvisiblemove.webknossos.xyz to see whether it's an improvement with regard to #5233. |
Thanks! Yes, my use case is handled better now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, feels exactly right now :)
LGTM once the temporary changes are reversed 👍
This PR removes the old "clamp to edge" behavior on initial third-dimension movements, since this had undesired side effects (such as #5233). As a replacement, the keyboard delay is adapted according to the current position. See code comments for more details.
URL of deployed dev instance (used for testing):
https://fixvisiblemove.webknossos.xyz
Steps to test:
Issues: