Fix histogram sampling for tiny datasets #5458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position sampling for histogram and find data roughly works like a menger sponge, with a stopping criterion when the distance between the sampling points becomes too close. For tiny datasets, the first iteration already runs into the stopping criterion.
The fix is to always add the 32vx³ bucket at 0,0,0 to the position list. This way, the data from this corner (which tends to exist for tiny datasets) is included.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: