Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram request fails for tiny datasets #5444

Closed
fm3 opened this issue Apr 30, 2021 · 2 comments · Fixed by #5458
Closed

Histogram request fails for tiny datasets #5444

fm3 opened this issue Apr 30, 2021 · 2 comments · Fixed by #5458

Comments

@fm3
Copy link
Member

fm3 commented Apr 30, 2021

If the bounding box of a dataset is tiny (e.g. 50 × 50 × 30 voxel³) the histogram request fails.
The position sampling runs into breaking criterion spaceBetweenWidth < DataLayer.bucketLength already in the first iteration. How can we create a sampling strategy that also returns valid data for arbitrarily small datasets?

@fm3
Copy link
Member Author

fm3 commented May 2, 2021

We could also discuss if the histogram request failing should cause an error toast at all.
This is a quite prominent error coming up on page load even if the user wasn’t actually intersted in the histogram. The request may still sometimes fail for one reason or the other even after this small-dataset issue is fixed. Do you think we should possibly instead show an error message in place of the histogram in the sidebar? @philippotto @normanrz

@normanrz
Copy link
Member

normanrz commented May 2, 2021

instead show an error message in place of the histogram in the sidebar

That is a good idea. However, I'd rather focus dev work on fixing the histogram computation than the error message :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants