Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Fixes for Tiff Export #5252

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Small Fixes for Tiff Export #5252

merged 2 commits into from
Mar 9, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 8, 2021 •
edited
Loading

Steps to test:

  • set jobsEnabled = true in application.conf
  • bounding box of export jobs should now be visible in jobs list view
  • when attempting to export from a dataset of a different orga, a readable error message should be shown
  • when exporting from view mode or skeleton-only annotation, segmentation layer should be available in export modal (volume without fallback is the only case where it should be hidden)

Issues:

  • Ready for review

@fm3 fm3 self-assigned this Mar 8, 2021
@fm3 fm3 marked this pull request as ready for review March 8, 2021 17:49
@fm3 fm3 requested a review from philippotto March 8, 2021 17:49
@fm3 fm3 mentioned this pull request Mar 9, 2021
Merged
16 tasks
philippotto
philippotto approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front-end looks good to me 👍 I only made "optional" suggestions.

frontend/javascripts/oxalis/view/settings/export_bounding_box_modal.js Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/view/settings/export_bounding_box_modal.js Show resolved Hide resolved
frontend/javascripts/admin/job/job_list_view.js Outdated Show resolved Hide resolved
@fm3 fm3 enabled auto-merge (squash) March 9, 2021 14:05
@fm3 fm3 merged commit 9c2b58a into master Mar 9, 2021
@fm3 fm3 deleted the tiff-export-fixes branch May 3, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
backend bug enhancement frontend
Projects
None yet
Milestone
No milestone
2 participants
@fm3 @philippotto