Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Volume Annotations #5246

Merged
merged 9 commits into from
Mar 16, 2021
Merged

Export Volume Annotations #5246

merged 9 commits into from
Mar 16, 2021

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 8, 2021

image

Note that #5252 should be merged first (some of the bugs fixed there could crop up here too during testing)

TODO (includes changes in https://github.com/scalableminds/webknossos-worker/pull/6/ )

  • fetch volume annotations
  • merge with fallback layer
  • pass result to cuber
  • are compound tracings cached long genough? → increased to 70 min, created follow-up issue In Tracingstore, move temporary data from local cache to Redis #5255
  • use glob instead of exists
  • pass version
  • pass token only for this job
  • pass tracing id from frontend
  • don’t include fallback layer if it is unlinked
  • test resulting files with imagemagick (convert 000002.tiff -evaluate multiply 200 -depth 8 8.tif)
  • adapt job description in list view
  • disable buttons already in frontend if mag1 is not present
  • ensure saved state
  • clean up intermediate files? (let’s leave them in for the moment, for debugging. clean-up job issue Add expiry + clean up job for exported files #5202)

Steps to test:

  • set up https://github.com/scalableminds/webknossos-worker/pull/6/
  • set jobsEnabled = true in application.conf
  • open volume annotation (also try hybrid, skeleton, view mode)
  • brush some, create bbox
  • click export tif button, modal should show annotation layer
  • zip download from jobs list should include segmentation tifs with the annotations
  • modals should not contain typos

Issues:


@fm3 fm3 changed the title [WIP] export volume annotations Export Volume Annotations Mar 9, 2021
@fm3 fm3 marked this pull request as ready for review March 9, 2021 12:24
@fm3 fm3 mentioned this pull request Mar 9, 2021
1 task
@fm3 fm3 requested review from philippotto and youri-k March 9, 2021 16:07
@fm3
Copy link
Member Author

fm3 commented Mar 10, 2021

Another idea: might be worth to save the “referrer” link with the job (e.g. to go back to the source (compound) annotation the tiffs were exported from. The tracing id is not sufficient for this lookup in compound case.

Edit: created follow-up issue for that #5261

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front-end looks great! will test now.

Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested it, but the backend code looks good 🎉

@fm3 fm3 merged commit d80c8a9 into master Mar 16, 2021
@fm3 fm3 deleted the export-volume-annotations branch March 16, 2021 12:28
@cnzqy1 cnzqy1 mentioned this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiff Export for Volume Annotations
3 participants