Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Multi-Component Trees in Backend NML Parser #4688

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Split Multi-Component Trees in Backend NML Parser #4688

merged 7 commits into from
Jul 8, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Jun 29, 2020 •
edited
Loading

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • upload NML with at least one multicomponent tree (that is in the root group)
  • upload NML with at least one multicomponent tree (that is in a tree group)
  • test NMLs can be found at multicomponent-test-nmls.zip
  • should result in two distinct trees, wrapped in a new tree group
  • uploading NML with no multicomponent trees should not be significantly slower

Issues:

@fm3 fm3 added the backend label Jun 29, 2020
@fm3 fm3 self-assigned this Jun 29, 2020
@fm3 fm3 marked this pull request as ready for review July 6, 2020 09:47
@fm3 fm3 changed the title [WIP] split multicomponent trees in backend nml parser Split Multi-Component Trees in Backend NML Parser Jul 6, 2020
@fm3 fm3 requested a review from youri-k July 6, 2020 09:58
youri-k
youri-k approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@fm3 fm3 merged commit 836a35d into master Jul 8, 2020
@fm3 fm3 deleted the backend-split-tree-components branch July 8, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make import of NMLs more resilient
2 participants
@fm3 @youri-k