Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make import of NMLs more resilient #4374

Closed
philippotto opened this issue Dec 11, 2019 · 5 comments · Fixed by #4688
Closed

Make import of NMLs more resilient #4374

philippotto opened this issue Dec 11, 2019 · 5 comments · Fixed by #4688
Assignees

Comments

@philippotto
Copy link
Member

philippotto commented Dec 11, 2019

To make it easier to switch from Knossos to WK, the import of NMLs should support:

Might need to happen in front-end in back-end.

@philippotto philippotto changed the title Support import of NMLs with unconnected components in one tree Make import of NMLs more resilient Dec 11, 2019
@hotzenklotz
Copy link
Member

NML for reference:
test.k 1.zip

Timestamps also seem to differ in various NML importer/exporters out there. Perhaps we can ignore those on import when they don't match. Or replace them with the current time etc.

@philippotto
Copy link
Member Author

Related to #4396.

@philippotto
Copy link
Member Author

Let's do it in front-end first.

@daniel-wer
Copy link
Member

Frontend is done and merged.

@daniel-wer daniel-wer removed their assignment May 4, 2020
@fm3
Copy link
Member

fm3 commented Jun 29, 2020

The knossos-generated NML is accepted by our back-end parser. It also handles unnamed trees. So I suppose the only thing left there is splitting unconnected-component-trees. This should replace TreeValidator.checkTreesAreConnected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants