-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NML import more performant and resilient #4541
Conversation
…assign same timetamp for trees as backend
…ilient-nml-import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top notch work 🎉 I only left some minor performance ideas which should be easy to integrate.
/edit: Also tested the provided NMLs and everything worked fine 👍
Thanks for the review, I updated flow to a somewhat newer version, because the |
@philippotto Could you have a look at my new changes and maybe test whether |
After I upgraded node to v12, everything worked fine :) Maybe post a PSA in slack after this is merged? |
Absolutely, will do, thanks for testing :) |
Ideally, I'd like to avoid the redefinition of the
MutableTree
type and, therefore, experimented with recursive read-only instructions for flow, but I couldn't get those to work for the diffable maps :/(for reference, the most success I had was with the solution outlined in facebook/flow#5844 (comment))
URL of deployed dev instance (used for testing):
Steps to test:
Issues: