-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if outside of bounding box #4544
Conversation
Cool stuff :) Was curious about the "out of bounding box feature" and had to check it out. I've got some visual feedback: I find the orange background a bit too much. I'd change it from: I used the followng css style for the pin-icon div and the position string div:
Also, I'd change the tooltip text to "The current position is outside of the dataset's bounding box. No data will be shown here." |
Thanks for your feedback @philippotto.
I think this message is not fitting if the user is outside of the task bounding box. Should I adjust the message in that case? e.g.: |
I just tried annotation outside of the task bounding box and noticed that this is possible. Thus I'll change
to
|
@daniel-wer @philippotto One question I got left is: Shall the rotation view also be colored in the warning color and be included in the container that has the error tooltip? |
@MichaelBuessemeyer If it's easy I would only apply the style to the position box as the warning refers to the user's position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of great fixes! I added some comments and would like to talk and understand the solution for the TD-View rotation center change :)
…n-if-outside-of-bbox * includes adding missing changelog entries
* get rid of constuctor, state, getDerivedStateFromProps
@daniel-wer I just implemented your last feedback (see my comment). I can confirm that the fix still works on my laptop. Could you please check this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome fixes, LGTM 🎉
This PR adds a warning to the position view in tracings if the position is out of bounds.
Additionally this PR resolves issue #4336 by adding the error message to the ignored list.
The bug from #4472 is also fixed here.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment