Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selecting node in 3d viewport does not immediately change rotation center #4472

Closed
fm3 opened this issue Mar 10, 2020 · 6 comments · Fixed by #4544
Closed

selecting node in 3d viewport does not immediately change rotation center #4472

fm3 opened this issue Mar 10, 2020 · 6 comments · Fixed by #4544
Assignees

Comments

@fm3
Copy link
Member

fm3 commented Mar 10, 2020

if i shift+click a node in the 3d viewport the rotation center changes. however, it does so only after moving around a bit. would be nice if that could happen immediately

@MichaelBuessemeyer
Copy link
Contributor

@fm3 I cannot reproduce this bug. At least the way I understand you issue.
The code clearly sets the node selected with shift+click active. Then a saga / background process sets the position and rotation center to the active node.
Here is what happens on my laptop in chrome (the same goes for firefox):
rotation-center
As you can see the rotation center is updated immediately or do I misunderstand you completely?

@fm3
Copy link
Member Author

fm3 commented Apr 13, 2020

Thanks for investigating this! Turns out my use case was more specific: I’m selecting the node in the 3d viewport. In fact, my view configuration showed only the 3d viewport.

@MichaelBuessemeyer
Copy link
Contributor

@fm3 Thanks for your reply and description of how to reproduce this bug. However I still cannot reproduce this error, even when only the 3d viewport is visible. The rotation center is always immediately updated.
rotation-center

Note: in both videos I selected the node via the 3d viewport.

@fm3
Copy link
Member Author

fm3 commented Apr 13, 2020

In the second video, right after you select the lower node you rotate again but it still rotates around the node on top for about two seconds, can you see what I mean? That’s my symptom. Only after you then release the mouse again and then click again to rotate, the updated center is used. Not sure how to explain in more detail.

@MichaelBuessemeyer
Copy link
Contributor

MichaelBuessemeyer commented Apr 13, 2020

@fm3 Thanks to your help I found the bug. The center is updated during an animation. #4544 will try to remove the 🐛

@MichaelBuessemeyer
Copy link
Contributor

The bug will be resolved with #4544 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants