-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also load up to three fallback layers for 'best quality first' #4470
Also load up to three fallback layers for 'best quality first' #4470
Conversation
Looks to me like this PR also resolves #4329 🧐 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Also load up to three fallback layers for 'best quality first'
-part works perfectly 👍
In the changes in the comment tab, I found only one thing in the code.
While testing the memoized version of the comment tab, I noticed that either the diffing between versions of the trees or that the relevant actions are not complete. At least these are my guesses.
Here is the "bug free" master:
And here is your branch on my local machine:
Could you please fix this before merging?
frontend/javascripts/oxalis/view/right-menu/comment_tab/comment_tab_view.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/right-menu/comment_tab/comment_tab_view.js
Outdated
Show resolved
Hide resolved
btw: Awesome idea to also memoize the tree-data 🚀 |
d8a3817
to
5e6f1dd
Compare
Sorry, this was not my intention. I removed these changes again and created a new PR for them. Could you please re-review/accept the current PR? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Also load up to three fallback layers for 'best quality first'-part works perfectly 👍
I suppose that this still works as I cannot test this again at the moment. But this should not block this PR 😄
Feel free to merge
…thub.com:scalableminds/webknossos into deeper-fallback-rendering-for-best-quality-first
Right now, the rendering strategies define how many fallback magnifications will be loaded so that these can be rendered. For progressive loading, three fallback magnifications are loaded. For best quality, only one fallback mag was loaded until now. The reasoning behind this was that additional fallbacks shouldn't be necessary (since they are loaded with lower priority). However, this had the effect that missing data couldn't be covered by fallback data if that fallback was more than one mag apart.
I simply changed the value of how many fallback mags should be loaded to three. This can produce more traffic, but since the lower mags have lower priority when using "best quality first", this shouldn't affect the perceived loading speed.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment