Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The comment tab can be quite slow when there are lots of comments #4329

Closed
philippotto opened this issue Nov 20, 2019 · 0 comments · Fixed by #4473
Closed

The comment tab can be quite slow when there are lots of comments #4329

philippotto opened this issue Nov 20, 2019 · 0 comments · Fixed by #4473
Assignees
@philippotto
Labels
frontend performance

Comments

@philippotto
Copy link
Member

getDerivedStateFromProps is a major performance bottleneck when there are lots of trees with comments. Even clicking on one comment can take up to 7 seconds until something happens. The culprit is most likely the sorting in getDerivedStateFromProps which could be easily cached (and maybe optimized in another way, as well).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippotto philippotto

Labels
frontend performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase performance of comments tab scalableminds/webknossos
1 participant
@philippotto