Replace Create Explorative buttons by Links #4410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philippotto Could you have a look if this is a sensible way of doing this? Also, I don’t know how to combat the flow errors in router.js (all the things parsed from the url can be null or undefined, apparently) |
philippotto
approved these changes
Jan 17, 2020
hotzenklotz
requested changes
Feb 12, 2020
| to={`/datasets/${dataset.owningOrganization}/${ | ||
| dataset.name | ||
| }/createExplorative/${type}/true`} | ||
| title={`Create ${typeCapitalized} Tracing`} |
There was a problem hiding this comment.
Suggested change
| title={`Create ${typeCapitalized} Tracing`} | |
| title={`Create ${typeCapitalized} Annotation`} |
| to={`/datasets/${dataset.owningOrganization}/${ | ||
| dataset.name | ||
| }/createExplorative/${type}/false`} | ||
| title={`Create ${typeCapitalized} Tracing`} |
There was a problem hiding this comment.
Suggested change
| title={`Create ${typeCapitalized} Tracing`} | |
| title={`Create ${typeCapitalized} Annotation`} |
| @@ -428,6 +434,42 @@ class ReactRouter extends React.Component<Props> { | |||
| /> | |||
| )} | |||
| /> | |||
| <Route | |||
|
superseded by new implementation in #4439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: