Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better onboarding on demo instance #4439

Merged
merged 90 commits into from
Apr 9, 2020
Merged

Better onboarding on demo instance #4439

merged 90 commits into from
Apr 9, 2020

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Feb 12, 2020

Lots of improvements for new users on webknossos.org:

  • Signup on frontpage
  • 1 organization per new user
  • Public Datasets hidden in list (only on demo)
  • Show featured publications in dashboard
  • New user banner with information
  • Better welcome email
  • Improved info tab in annotation view
  • Renamed tracing -> annotation
  • Improved docs
  • Refactored DatasetCache from Dashboard in own component with context

normanrz and others added 30 commits February 11, 2020 14:37
…os into better-onboarding

* 'better-onboarding' of github.com:scalableminds/webknossos:
  flow
  lint
  help texts
  extra sharing tab in dataset edit
  rename scale to voxel size
  improved signup
  rename tracing to annotation in user-facing texts
  flow
  faq on pricing
  dataset filtering
@fm3
Copy link
Member Author

fm3 commented Mar 4, 2020

@normanrz I added the organizationDisplayName to the query as specified. if organization is emptystring, the backend will use a normalized version of organizationDisplayName for the name.
Also, I added /organizations/:organizationName as you requested as well as restricting /organizations so that it will fail if there are multiple organizations on the server. I did not yet adapt the frontend to those changes (except for setting some values to default values so that the requests don’t fail)

@normanrz
Copy link
Member

normanrz commented Mar 4, 2020

@fm3 For deployments with a single org, can we have a route like /api/organizations/default that returns the single org?

Also, the "organziation team" uses the cryptic org name, can we change that to something more generic like "Default"?

@philippotto
Copy link
Member

What's the status here?

@normanrz
Copy link
Member

I think the code should be ready, but I need to do one more round of checking.

@fm3
Copy link
Member Author

fm3 commented Mar 17, 2020

I didn’t do the frontend changes for switching to /organizations/default, I guess those are still to do?

@philippotto
Copy link
Member

@fm3 I just merged the master into this PR and resolved most of the conflicts. However, there are still conflicts in app/controllers/Authentication.scala which I didn't feel comfortable to resolve. Could you have a look at these if you have a minute? :)

@philippotto
Copy link
Member

@fm3 Sorry to bug you again, but the getDefaultOrganization route returns an error message (à la "cannot list organizations due to privacy reasons"), but the front-end cannot know whether this is an multi-orga setup or not (at least, I don't think so). Could you just return null if there are multiple organizations?

@philippotto philippotto merged commit da2b3cc into master Apr 9, 2020
@fm3 fm3 deleted the better-onboarding branch May 19, 2020 21:26
@fm3 fm3 mentioned this pull request Nov 19, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants