-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tables horizontally scrollable on overflow and add wordbreak in tables #4136
Conversation
making the dataset name clickable to view is in progress
…e-tables-scrollable
@philippotto This PR is also be ready for your review 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
I think the scrollbar never appears, though. Since the "word wrap" property will always split words further. See here:
Can you add a min-width
property to the tables? Maybe a minimum of 800px? In this case, the page should show a horizontal scrollbar (might need some other CSS voodoo for that :)).
…e-tables-scrollable
…knossos into make-tables-scrollable
@philippotto I applied your feedback. As tables are often used in wk, and I did not check whether all tables look fine, with the fix, I only applied it to the dataset table. If you think there should be a fix like this for all tables please let me know. P.S.: If the second paragraph does not apply, my PR is ready for your review :) |
The table itself looks good now, but the horizontal scrollbar is not visible for me :/ Does it appear for you? |
Yes, it works for me. The scrollbar is displayed at the bottom directly above the pagination. It works in firefox and chrome. 🤔 |
Ok, I found the scrollbar :D Ideally, it wouldn't be at the very bottom of the page but at the bottom of the window. But unless you feel like massaging the CSS further, I think it's sufficient for now. |
frontend/javascripts/dashboard/advanced_dataset/dataset_table.js
Outdated
Show resolved
Hide resolved
…e-tables-scrollable
I tried it some time, but could not get it working :/ |
This PR adds CSS rule to make tables horizontally scrollable when the screen/container of the table is not wide enough to display the whole table. It also adds the word-break property to the table data to force long words in a table cell to be written in multiple lines.
Additionally, this PR adds the possibility of clicking on the dataset name in the dataset table (dashboard) to open the dataset in view mode.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment