Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that antd tables are not too wide #4106

Closed
philippotto opened this issue May 23, 2019 · 8 comments · Fixed by #4136, #4207 or #4245
Closed

Ensure that antd tables are not too wide #4106

philippotto opened this issue May 23, 2019 · 8 comments · Fixed by #4136, #4207 or #4245
Assignees

Comments

@philippotto
Copy link
Member

Can be provoked by zooming in.

@hotzenklotz
Copy link
Member

Start Tracing etc is cut off on the right-hand side.

image

@philippotto
Copy link
Member Author

philippotto commented May 23, 2019

@normanrz
Copy link
Member

Would also be great if one could click the name to view the dataset.

@normanrz
Copy link
Member

normanrz commented Jul 4, 2019

This is not ideal yet. On my monitor, I always have to scroll although there is plenty of empty space.

Bildschirmfoto 2019-07-04 um 11 54 36

@normanrz normanrz reopened this Jul 4, 2019
@hotzenklotz
Copy link
Member

hotzenklotz commented Jul 10, 2019

Same here. I just briefly looked at the changes. Forcing the table column's to have a minimum width does not seem like a smart workaround. This always forces the table out of my 15" screen even though, the columns could be smaller. (In fact some columns define their width in the react code explicitly, which is overwritten by the CSS)

.large-table table > thead > tr > th:not(.ant-table-expand-icon-th) {
  min-width: 200px;
}

I wonder if removing the min-width is enough to solve this issue, or if it will break overflowing again.

With min-width: (Note the overflow)
image

Without min-width:
image

@normanrz
Copy link
Member

If you don't set a min-width or width, the table will never overflow the viewport and always squeeze into the existing space. See #4136 (review)

@MichaelBuessemeyer
Copy link
Contributor

(In fact some columns define their width in the react code explicitly, which is overwritten by the CSS)

Completely removing the general min-width and defining it for each column separately sounds good to me.

The current version is not correct as you can see below (This is the explorative annotations table).

image

@normanrz

If you don't set a min-width or width, the table will never overflow the viewport and always squeeze into the existing space

This is (afaik) correct, but some columns do not need to have a 200px min-width so we have to reduce it for them manually.

@MichaelBuessemeyer
Copy link
Contributor

MichaelBuessemeyer commented Aug 16, 2019

@philippotto @normanrz Repoening this as the problem still exists for chrome.
width-bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment