Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use full prefix in sitemap urls #4035

Merged
merged 10 commits into from
Apr 25, 2019
Merged

Use full prefix in sitemap urls #4035

merged 10 commits into from
Apr 25, 2019

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Apr 23, 2019

URL of deployed dev instance (used for testing):

Steps to test:

  • visit /sitemap.xml
  • test also on localhost
  • urls should be correct

@fm3 fm3 added the backend label Apr 23, 2019
@fm3 fm3 requested a review from youri-k April 23, 2019 10:53
@fm3 fm3 self-assigned this Apr 23, 2019
youri-k
youri-k approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@youri-k youri-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@fm3 fm3 merged commit 31ce8ef into master Apr 25, 2019
@fm3 fm3 deleted the fix-sitemap branch April 25, 2019 08:48
hotzenklotz added a commit that referenced this pull request Apr 27, 2019
@hotzenklotz
Merge branch 'mobile' of github.com:scalableminds/webknossos into mobile
283a77d 
* 'mobile' of github.com:scalableminds/webknossos:
  Stricter health checks for datasets (#4011)
  dont rely on type conversion in find data #3936 (#4007)
  Use full prefix in sitemap urls (#4035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youri-k youri-k youri-k approved these changes

Assignees

@fm3 fm3

@youri-k youri-k

Labels
backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fm3 @youri-k