Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find data generalisation #4007

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Find data generalisation #4007

merged 4 commits into from
Apr 25, 2019

Conversation

youri-k
Copy link
Contributor

@youri-k youri-k commented Apr 11, 2019 •
edited by fm3
Loading

  • dont rely on explicit type conversion

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Test the find data button

Issues:

@youri-k youri-k self-assigned this Apr 11, 2019
@youri-k youri-k requested a review from fm3 April 11, 2019 13:16
fm3
fm3 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems to work :) Thanks!

@youri-k youri-k merged commit 6cc8938 into master Apr 25, 2019
hotzenklotz added a commit that referenced this pull request Apr 27, 2019
@hotzenklotz
Merge branch 'mobile' of github.com:scalableminds/webknossos into mobile
283a77d 
* 'mobile' of github.com:scalableminds/webknossos:
  Stricter health checks for datasets (#4011)
  dont rely on type conversion in find data #3936 (#4007)
  Use full prefix in sitemap urls (#4035)
@normanrz normanrz deleted the find-data-generalisation branch August 12, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees

@youri-k youri-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find data route does not support uint24 layers
2 participants
@youri-k @fm3