Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow uploading nml for public dataset of different orga #3929

Merged
merged 4 commits into from
Mar 25, 2019
Merged

allow uploading nml for public dataset of different orga #3929

merged 4 commits into from
Mar 25, 2019

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 20, 2019

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • create second organization, set a dataset to public
  • download an nml for that dataset, re-upload (as user of non-owning orga)
  • should work
  • uploading nml for non-public dataset of other orga should still be forbidden

Issues:

@fm3 fm3 self-assigned this Mar 20, 2019
@fm3 fm3 requested review from youri-k and jstriebel March 20, 2019 21:33
jstriebel
jstriebel approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fm3 fm3 merged commit a5d53b2 into master Mar 25, 2019
@fm3 fm3 deleted the nml-upload-differnt-orga branch March 25, 2019 12:13
hotzenklotz added a commit that referenced this pull request Mar 25, 2019
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into fea…
5b3acc1 
…ture-highlight

* 'master' of github.com:scalableminds/webknossos:
  Hide unreported datasets (#3883)
  Update puppeteer and refresh screenshots (#3914)
  only show team names of own organization (#3928)
  Enable merger mode in skeleton and hybrid tracings (#3619)
  allow uploading nml for public dataset of different orga (#3929)
  Always make wheel listeners not passive to allow preventDefault (#3939)
  Enhance tree search functionallity (#3878)
  add webknossos-connect to setup (#3913)
  Update README.md (#3923)
  Add shortcut to maximize golden layout panes (#3927)
  Perform bucket picking in web workers and other performance optimizations (#3902)
  remove alt text for abstract brain loading image (#3930)
  updated documentation front page (#3917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstriebel jstriebel jstriebel approved these changes

@youri-k youri-k Awaiting requested review from youri-k

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NML upload public dataset fails
2 participants
@fm3 @jstriebel