only show team names of own organization #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
commented
Mar 20, 2019
| requestingUserTeamManagerMemberships: Option[List[TeamMembership]] = None): Fox[JsObject] = { | ||
| implicit val ctx = GlobalAccessContext | ||
| requestingUserTeamManagerMemberships: Option[List[TeamMembership]] = None)( | ||
| implicit ctx: DBAccessContext): Fox[JsObject] = |
There was a problem hiding this comment.
Quick comment to reviewer: Changing the AccessContext here to be more restrictive is not actually the fix (since the allowed teams db request has no AccessQuery), just something I noticed on the way.
There was a problem hiding this comment.
Probably it is not possible, but can't we just add an access query for the allowed teams request?
There was a problem hiding this comment.
I agree that that would be nice, however, the access query mechanism is not prepared for queries with joins in them. In those cases we filter/assert access in the scala code atm. Changing that would require changing all the access queries, unfortunately
hotzenklotz
added a commit
that referenced
this pull request
Mar 25, 2019
…ture-highlight * 'master' of github.com:scalableminds/webknossos: Hide unreported datasets (#3883) Update puppeteer and refresh screenshots (#3914) only show team names of own organization (#3928) Enable merger mode in skeleton and hybrid tracings (#3619) allow uploading nml for public dataset of different orga (#3929) Always make wheel listeners not passive to allow preventDefault (#3939) Enhance tree search functionallity (#3878) add webknossos-connect to setup (#3913) Update README.md (#3923) Add shortcut to maximize golden layout panes (#3927) Perform bucket picking in web workers and other performance optimizations (#3902) remove alt text for abstract brain loading image (#3930) updated documentation front page (#3917)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test:
Issues:
[ ] Updated changelog[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment