-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seamless fallback #3801
Seamless fallback #3801
Conversation
…late as possible; remove most of binary fallback rendering code (disables fallback rendering for now)
...vascripts/oxalis/model/bucket_data_handling/bucket_picker_strategies/flight_bucket_picker.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thanks for all the effort in improving the code quality and flexibility of the GPU rendering!
I'll have a look at whether it's easy to migrate the existing recommendedConfigurations.
Will test now :)
frontend/javascripts/oxalis/model/bucket_data_handling/bucket.js
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/model/bucket_data_handling/texture_bucket_manager.js
Show resolved
Hide resolved
frontend/javascripts/oxalis/view/settings/dataset_settings_view.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked really well during testing for me, I didn't experience any black spots 👍
I did notice a lower frame rate during flight mode tracing (compared to orthogonal) - ~15FPS compared to ~30FPS and it felt kinda laggy, but I can't say how that compares to the status quo. Let's see what our testers say :)
…er documentation for settings
…os into seamless-fallback
This PR rewrites the logic for fallback rendering. In short:
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
Todo:
find better fix for flight mode bucket picking inaccuracyNeeds datastore update after deployment