-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bravenewworld skeletons #1957
Merged
Merged
Bravenewworld skeletons #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some routes by temporary stubs
…rsion number and timestamp (#1900)
…up-update-actions
…in AnnotationMerger (WIP)
…knossos into bravenewworldSkeletons * 'bravenewworldSkeletons' of github.com:scalableminds/webknossos: fix flow + linting + pretty
…venewworldSkeletons
@hotzenklotz Very thorough testing indeed, thanks a lot! I applied your PR feedback and answered your questions :) |
* master: pretty me bump libs version number fix token access; bump braingames version (#2085) removed unused backbone model #2009 move dataset uploading into Rest API module #2009 enabled file preview hint before upload new dataset #2009 reactified dataset upload view #2209 Changed schema after tests #2055 Further implementation of PR review advices #2055 Implemented first part of review comments #2055 prepared schemas for PR #1929 changed DataToken to UUID and created a List of things ToDo to make the db valid #1929 prettified files and added one error #1929 even better schemas and added list of errors #1929 Fixed schemas and added a script to test validation #1929 Added checks for arrays #1929 refined schemas with regex almost finished #1929 started on sub-document validation Fixed dataStores.schema.js renamed files and made files prettier #1929
hotzenklotz
added a commit
that referenced
this pull request
Nov 3, 2017
…ct-task-create * 'master' of github.com:scalableminds/webknossos: (167 commits) Enable interpolation setting in volume mode (#2089) allow admins to administrate datasets fix compilation update libs remove jsRoutes from tests apply PR feedback (#1957) removed github conf fixed lint make flow happy fix merge conflicts in frontend Changed schema after tests #2055 merge master. TODO: fix flow errors, test volume fallback layer remove obsolete version field from annotation (only tracings are versioned now) Further implementation of PR review advices #2055 Implemented first part of review comments #2055 remove obsolete todo log time for the user who sent the updates, not for the annotation owner use new libs version update libs version disable e2e tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailable description of changes:
Steps to test:
List of frontend changes:
This is an array of batched update actions. One batch is the result of one action in the webknossos frontend (e.g.: splitting a tree by removing a node). Each batch has a version number, a timestamp, a list of update actions and optionally a stats object that contains node/edge/.. count statistics.
jsRoutes were removed
Annotation, tracing and dataset are now fetched separately (the annotation is the meta data for a tracing, the tracing are the trees, comments and so on)
there is now a distinction between the annotationId and the tracingId
several json properties were renamed on the server (look at the server flow types in
model.js
andapi_flow_types.js
)the view mode (look at dataset only) was refactored to no longer need an annotation and tracing
the strange form-construct that was used in the advanced dataset list view to start skeleton/volume tracings was replaced with simple links
routes that start with
/data/
(and therefore address the datastore) need a token parameter now (use thedoWithToken
wrapper method)voxels that were labeled during a volume tracing are now pushed to the server using the standard save queue instead of the dedicated push queue
Issues: