Reactify Dataset Upload View #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippotto
approved these changes
Oct 27, 2017
There was a problem hiding this comment.
Looks very good :) However, I get an error when uploading a dataset due to timing problems. The front-end seems to be to fast for the server? Since it is not obvious that a simple refresh can fix the problem, I'd strongly suggest to either "sleep" in the front-end and/or to show a message à la: "An error occurred. Please refresh the page to retry".
| @@ -1,12 +0,0 @@ | |||
| import Backbone from "backbone"; | |||
…ct-dataset-upload * 'master' of github.com:scalableminds/webknossos: remove all the unused files removed unused import #2009 removed task overview view #2009 remove unused workload view #2009 fixed flow types for team creation #2009 added flow header to project creation #2009 updated snapshots #2009 restored pausing/resuming of tasks #2009 restored creation of MTurk projects #2009 restored project editting #2009 reactified project creation view #2009
hotzenklotz
added a commit
that referenced
this pull request
Oct 31, 2017
…ct-task-create * 'master' of github.com:scalableminds/webknossos: remove mongev plugin, fixes #2072 pretty me bump libs version number fix token access; bump braingames version (#2085) removed unused backbone model #2009 move dataset uploading into Rest API module #2009 enabled file preview hint before upload new dataset #2009 reactified dataset upload view #2209
hotzenklotz
added a commit
that referenced
this pull request
Nov 2, 2017
…veNewWorldSkeletons * 'master' of github.com:scalableminds/webknossos: pretty me bump libs version number fix token access; bump braingames version (#2085) removed unused backbone model #2009 move dataset uploading into Rest API module #2009 enabled file preview hint before upload new dataset #2009 reactified dataset upload view #2209 Changed schema after tests #2055 Further implementation of PR review advices #2055 Implemented first part of review comments #2055 prepared schemas for PR #1929 changed DataToken to UUID and created a List of things ToDo to make the db valid #1929 prettified files and added one error #1929 even better schemas and added list of errors #1929 Fixed schemas and added a script to test validation #1929 Added checks for arrays #1929 refined schemas with regex almost finished #1929 started on sub-document validation Fixed dataStores.schema.js renamed files and made files prettier #1929
hotzenklotz
added a commit
that referenced
this pull request
Nov 2, 2017
* master: pretty me bump libs version number fix token access; bump braingames version (#2085) removed unused backbone model #2009 move dataset uploading into Rest API module #2009 enabled file preview hint before upload new dataset #2009 reactified dataset upload view #2209 Changed schema after tests #2055 Further implementation of PR review advices #2055 Implemented first part of review comments #2055 prepared schemas for PR #1929 changed DataToken to UUID and created a List of things ToDo to make the db valid #1929 prettified files and added one error #1929 even better schemas and added list of errors #1929 Fixed schemas and added a script to test validation #1929 Added checks for arrays #1929 refined schemas with regex almost finished #1929 started on sub-document validation Fixed dataStores.schema.js renamed files and made files prettier #1929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mailable description of changes:
Steps to test:
Goto Dashboard --> Dataset --> "Add Dataset Button"
Upload a dataset and check that I can be successfully views. Datasets can be downloaded from the wiki.
I have not idea how to test the NDstore tab
Attention before merging: This needs a braingames-lib version update for the datastore.
Issues: