Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix widen types before checking an implicit view exists" to LTS #19071

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Backport "Fix widen types before checking an implicit view exists" to LTS #19071

merged 3 commits into from
Dec 8, 2023

Commits on Nov 29, 2023

  1. report: Trim down enriched error messages 

    The implementation here comes from porting from nsc.  But I think
things were done differently enough with its Global state, that make it
not translate nicely here.  So I'm paring it down to what I know works
(at least for me): versions, settings, compilation unit.  Not the
tree/symbol/site stuff.

[Cherry-picked b120977]
    @dwijnand @Kordyjan
    dwijnand authored and Kordyjan committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    58ec964 View commit details
    Browse the repository at this point in the history

  2. report: Add a Y-flag to disable enriched error messages 

    [Cherry-picked e6fe320]
    @dwijnand @Kordyjan
    dwijnand authored and Kordyjan committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    cf87092 View commit details
    Browse the repository at this point in the history

  3. Fix widen types before checking an implicit view exists 

    It's not possible to convert a method, such as a polymorphic method,
such as `makeChurch`, into another type - we need to widen out the
TermRef to discover the underlying PolyType which isn't a value type.
Failing to do so will create a dummyTreeOfType, which will then be
attempted to be applied, which eventually causes an assertion crash
while building the tpd.TypeApply.

[Cherry-picked 8a2773f]
    @dwijnand @Kordyjan
    dwijnand authored and Kordyjan committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e80337f View commit details
    Browse the repository at this point in the history