Backport "Fix widen types before checking an implicit view exists" to LTS #19071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation here comes from porting from nsc. But I think things were done differently enough with its Global state, that make it not translate nicely here. So I'm paring it down to what I know works (at least for me): versions, settings, compilation unit. Not the tree/symbol/site stuff. [Cherry-picked b120977]
[Cherry-picked e6fe320]
It's not possible to convert a method, such as a polymorphic method, such as `makeChurch`, into another type - we need to widen out the TermRef to discover the underlying PolyType which isn't a value type. Failing to do so will create a dummyTreeOfType, which will then be attempted to be applied, which eventually causes an assertion crash while building the tpd.TypeApply. [Cherry-picked 8a2773f]
|
No regressions detected in the community build up to lts-16941. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #18719 to the LTS branch.
PR submitted by the release tooling.